[ https://issues.apache.org/jira/browse/HIVE-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063740#comment-13063740 ]
jirapos...@reviews.apache.org commented on HIVE-2260: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1014/#review1036 ----------------------------------------------------------- Changes look good. Is it possible to add a testcase? If not, can you update the jira how it is tested? - Amareshwari On 2011-07-06 00:45:12, Jakob Homan wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/1014/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-07-06 00:45:12) bq. bq. bq. Review request for hive. bq. bq. bq. Summary bq. ------- bq. bq. Currently when ExecDriver encounters a non-existent partition, it creates an empty file so that the query will be valid (and return 0 results). However, when it does this and calls getHiveRecordWriter(), it creates a new instance of Properties, rather than providing the Properties associated with the table. bq. bq. This causes RecordWriters that pull information from the table through the Properties to fail (such as Haivvreo). The RecordWriter should be provided the table's Properties, as it is in all other cases where it's called. bq. bq. bq. This addresses bug HIVE-2260. bq. https://issues.apache.org/jira/browse/HIVE-2260 bq. bq. bq. Diffs bq. ----- bq. bq. ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 4fba845 bq. bq. Diff: https://reviews.apache.org/r/1014/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Jakob bq. bq. > ExecDriver::addInputPaths should pass the table properties to the record > writer > ------------------------------------------------------------------------------- > > Key: HIVE-2260 > URL: https://issues.apache.org/jira/browse/HIVE-2260 > Project: Hive > Issue Type: Bug > Affects Versions: 0.7.0 > Reporter: Jakob Homan > Assignee: Jakob Homan > Attachments: HIVE-2260.patch > > > Currently when ExecDriver encounters a non-existent partition, it creates an > empty file so that the query will be valid (and return 0 results). However, > when it does this and calls {{getHiveRecordWriter()}}, it creates a new > instance of Properties, rather than providing the Properties associated with > the table. > This causes RecordWriters that pull information from the table through the > Properties to fail (such as [Haivvreo|http://bit.ly/iwEQzJ]). The > RecordWriter should be provided the table's Properties, as it is in all other > cases where it's called. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira