----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1132/#review1084 -----------------------------------------------------------
I mean you can just change the function name to something like estimateInputSize(). - Siying On 2011-07-15 20:48:38, Kevin Wilfong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1132/ > ----------------------------------------------------------- > > (Updated 2011-07-15 20:48:38) > > > Review request for hive and Siying Dong. > > > Summary > ------- > > A query should run in local mode when block sampling is used and the sample > is small enough. The size of the sample is currently being estimated, as it > is done to estimate the number of reducers. > > > This addresses bug HIVE-2282. > https://issues.apache.org/jira/browse/HIVE-2282 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java cd3de76 > ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyIsLocalModeHook.java > PRE-CREATION > ql/src/test/queries/clientpositive/sample_islocalmode_hook.q PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java 53769a0 > > Diff: https://reviews.apache.org/r/1132/diff > > > Testing > ------- > > TestCliDriver TestNegativeCliDriver, manually tested > > > Thanks, > > Kevin > >
