> On 2011-06-27 20:51:48, Carl Steinbach wrote: > > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java, > > line 91 > > <https://reviews.apache.org/r/958/diff/1/?file=21668#file21668line91> > > > > We should try to avoid making the metastore dependent on ql. There's > > already an open ticket (HIVE-850) that covers the task of moving > > SessionState to common. Looks like now may be a good time to do this. > > Patrick Hunt wrote: > I've refactored the log initialization code in order to allow reuse > (moved into common). Took a look at doing more like 850, but it looks like > that's going to be a much class to tease apart.
notice as part of this refactoring the log4j initialization method now throws an exception rather than silently ignoring the missing log4j.properties. When I built this (ant package) and run either the hiveserver or metastore it now complains about no log4j.properties found on the classpath (please give it a try). I added a log4j.properties to the conf dir and it was fine. It seems that the exec jar includes a log4j.properties, should other jars also? or it's just up to the user to address this? - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/958/#review919 ----------------------------------------------------------- On 2011-07-15 23:51:55, Patrick Hunt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/958/ > ----------------------------------------------------------- > > (Updated 2011-07-15 23:51:55) > > > Review request for hive and Carl Steinbach. > > > Summary > ------- > > This patch updates HiveServer and HiveMetastore to add proper cli handling - > similar to that used in CliDriver (ie GnuParser). > > There's a common HiveCli class that's used by both main classes. > > I've attempted to make the cli's backward compatible with the prior command > line processing. Notice I've "deprecated" (via warnings, but the code still > runs) if the old style CLI usage is used. > > commands such as the following now work as expected: > > bin/hive --service hiveserver -t 200 -p 12000 --hiveconf > hive.root.logger=DEBUG,console > > as does the following which generates usage information: > > bin/hive --service hiveserver -h > > Note: HiveMetastore as not initializing log4j, I updated the code to do > similar to HiveServer (otw the hiveconf hive.root.logger option above didn't > work). > > > This addresses bug HIVE-2139. > https://issues.apache.org/jira/browse/HIVE-2139 > > > Diffs > ----- > > ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 728958d > service/src/java/org/apache/hadoop/hive/service/HiveServer.java ea04be9 > ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 090ecfc > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 61393c8 > bin/ext/hiveserver.sh b5edce4 > bin/ext/metastore.sh db15f6e > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java bd9f6b1 > common/build.xml 0969e16 > common/ivy.xml bee3bf0 > common/src/java/org/apache/hadoop/hive/common/LogUtils.java PRE-CREATION > common/src/java/org/apache/hadoop/hive/common/cli/CommonCliOptions.java > PRE-CREATION > hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1bf8c97 > metastore/ivy.xml 83218fc > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > e540c63 > > Diff: https://reviews.apache.org/r/958/diff > > > Testing > ------- > > I couldn't find any tests for these changes, so I verfied the changes > manually. > > > Thanks, > > Patrick > >
