[
https://issues.apache.org/jira/browse/HIVE-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067933#comment-13067933
]
jirapos...@reviews.apache.org commented on HIVE-2139:
-----------------------------------------------------
bq. On 2011-07-19 00:08:19, Carl Steinbach wrote:
bq. > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java,
line 3382
bq. > <https://reviews.apache.org/r/958/diff/2/?file=26007#file26007line3382>
bq. >
bq. > This should be $METASTORE_PORT instead of HIVE_PORT (see
metastore.sh).
I missed that, thanks.
bq. On 2011-07-19 00:08:19, Carl Steinbach wrote:
bq. > common/build.xml, line 30
bq. > <https://reviews.apache.org/r/958/diff/2/?file=26001#file26001line30>
bq. >
bq. > This target overrides the definition of 'compile' in
build-common.xml, but neglects to include this action which copies over
hive-log4j.properties:
bq. >
bq. > <copy todir="${build.classes}" failonerror="false">
bq. > <fileset dir="${src.dir}/conf"/>
bq. > </copy>
bq. >
bq. > If this is added in I think the missing hive-log4j.properties issue
will be resolved.
Ok -- FYI I originally copied this section from cli/build.xml, not
build-common.xml. (it's the same except for this missing copy)
- Patrick
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/958/#review1106
-----------------------------------------------------------
On 2011-07-15 23:51:55, Patrick Hunt wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/958/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-15 23:51:55)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This patch updates HiveServer and HiveMetastore to add proper cli handling
- similar to that used in CliDriver (ie GnuParser).
bq.
bq. There's a common HiveCli class that's used by both main classes.
bq.
bq. I've attempted to make the cli's backward compatible with the prior
command line processing. Notice I've "deprecated" (via warnings, but the code
still runs) if the old style CLI usage is used.
bq.
bq. commands such as the following now work as expected:
bq.
bq. bin/hive --service hiveserver -t 200 -p 12000 --hiveconf
hive.root.logger=DEBUG,console
bq.
bq. as does the following which generates usage information:
bq.
bq. bin/hive --service hiveserver -h
bq.
bq. Note: HiveMetastore as not initializing log4j, I updated the code to do
similar to HiveServer (otw the hiveconf hive.root.logger option above didn't
work).
bq.
bq.
bq. This addresses bug HIVE-2139.
bq. https://issues.apache.org/jira/browse/HIVE-2139
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
728958d
bq. service/src/java/org/apache/hadoop/hive/service/HiveServer.java ea04be9
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 090ecfc
bq. ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 61393c8
bq. bin/ext/hiveserver.sh b5edce4
bq. bin/ext/metastore.sh db15f6e
bq. cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java bd9f6b1
bq. common/build.xml 0969e16
bq. common/ivy.xml bee3bf0
bq. common/src/java/org/apache/hadoop/hive/common/LogUtils.java PRE-CREATION
bq. common/src/java/org/apache/hadoop/hive/common/cli/CommonCliOptions.java
PRE-CREATION
bq. hwi/src/java/org/apache/hadoop/hive/hwi/HWISessionItem.java 1bf8c97
bq. metastore/ivy.xml 83218fc
bq. metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
e540c63
bq.
bq. Diff: https://reviews.apache.org/r/958/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I couldn't find any tests for these changes, so I verfied the changes
manually.
bq.
bq.
bq. Thanks,
bq.
bq. Patrick
bq.
bq.
> Enables HiveServer to accept -hiveconf option
> ---------------------------------------------
>
> Key: HIVE-2139
> URL: https://issues.apache.org/jira/browse/HIVE-2139
> Project: Hive
> Issue Type: Improvement
> Components: CLI
> Environment: Linux + CDH3u0 (Hive 0.7.0+27.1-2~lucid-cdh3)
> Reporter: Kazuki Ohta
> Assignee: Patrick Hunt
> Attachments: HIVE-2139.patch, HIVE-2139.patch
>
>
> Currently, I'm trying to test HiveHBaseIntegration on HiveServer. But it
> doesn't seem to accept -hiveconf command.
> {code}
> hive --service hiveserver -hiveconf hbase.zookeeper.quorum=hdp0,hdp1,hdp2
> Starting Hive Thrift Server
> java.lang.NumberFormatException: For input string: "-hiveconf"
> at
> java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
> at java.lang.Integer.parseInt(Integer.java:449)
> at java.lang.Integer.parseInt(Integer.java:499)
> at org.apache.hadoop.hive.service.HiveServer.main(HiveServer.java:382)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:186)
> {code}
> Therefore, you need to throw the query like "set
> hbase.zookeeper.quorum=hdp0,hdp1,hdp2" everytime. It's not convenient for
> separating the configuration between server-side and client-side.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
