[
https://issues.apache.org/jira/browse/HIVE-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068128#comment-13068128
]
jirapos...@reviews.apache.org commented on HIVE-2209:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/879/
-----------------------------------------------------------
(Updated 2011-07-20 02:25:36.169590)
Review request for hive and Yongqiang He.
Summary
-------
Patch for HIVE-2209
This addresses bug HIVE-2209.
https://issues.apache.org/jira/browse/HIVE-2209
Diffs
-----
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/CrossMapEqualComparer.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/FullMapEqualComparer.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MapEqualComparer.java
PRE-CREATION
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
2b77072
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/SimpleMapEqualComparer.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestCrossMapEqualComparer.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestFullMapEqualComparer.java
PRE-CREATION
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestSimpleMapEqualComparer.java
PRE-CREATION
Diff: https://reviews.apache.org/r/879/diff
Testing
-------
Tests added
Thanks,
Krishna
> Provide a way by which ObjectInspectorUtils.compare can be extended by the
> caller for comparing maps which are part of the object
> ---------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-2209
> URL: https://issues.apache.org/jira/browse/HIVE-2209
> Project: Hive
> Issue Type: Improvement
> Reporter: Krishna Kumar
> Assignee: Krishna Kumar
> Priority: Minor
> Attachments: HIVE-2209v0.patch, HIVE-2209v2.patch, HIVE2209v1.patch
>
>
> Now ObjectInspectorUtils.compare throws an exception if a map is contained
> (recursively) within the objects being compared. Two obvious implementations
> are
> - a simple map comparer which assumes keys of the first map can be used to
> fetch values from the second
> - a 'cross-product' comparer which compares every pair of key-value pairs in
> the two maps, and calls a match if and only if all pairs are matched
> Note that it would be difficult to provide a transitive
> greater-than/less-than indication with maps so that is not in scope.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
