-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1146/#review1174
-----------------------------------------------------------



trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/1146/#comment2463>

    Why is this NO_OF_THREADS_CAN_BE_LAUNCHED for sleeptime?
    



trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
<https://reviews.apache.org/r/1146/#comment2462>

    I don't think this is an improvement; it's better to see the rule 
definition inline.  If this was suggested by an automatic code scanner, 
probably tell it to ignore this instance.


- John


On 2011-07-20 14:36:59, chinna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1146/
> -----------------------------------------------------------
> 
> (Updated 2011-07-20 14:36:59)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> In Task class and its subclasses logger is initialized in constructor. Log 
> object no need to initialize every time in the constructor, Log object can 
> make it as static object.
> 
> 
> This addresses bug HIVE-2183.
>     https://issues.apache.org/jira/browse/HIVE-2183
> 
> 
> Diffs
> -----
> 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 
> 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 
> 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
> 1145025 
>   trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 1145025 
>   
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java
>  1145025 
> 
> Diff: https://reviews.apache.org/r/1146/diff
> 
> 
> Testing
> -------
> 
> All unit tests passed
> 
> 
> Thanks,
> 
> chinna
> 
>

Reply via email to