[
https://issues.apache.org/jira/browse/HIVE-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069854#comment-13069854
]
jirapos...@reviews.apache.org commented on HIVE-2183:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1146/#review1174
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/1146/#comment2463>
Why is this NO_OF_THREADS_CAN_BE_LAUNCHED for sleeptime?
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
<https://reviews.apache.org/r/1146/#comment2462>
I don't think this is an improvement; it's better to see the rule
definition inline. If this was suggested by an automatic code scanner,
probably tell it to ignore this instance.
- John
On 2011-07-20 14:36:59, chinna wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1146/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-20 14:36:59)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In Task class and its subclasses logger is initialized in constructor. Log
object no need to initialize every time in the constructor, Log object can make
it as static object.
bq.
bq.
bq. This addresses bug HIVE-2183.
bq. https://issues.apache.org/jira/browse/HIVE-2183
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/CopyTask.java 1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java
1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java
1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1145025
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 1145025
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java
1145025
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
1145025
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java
1145025
bq.
bq. Diff: https://reviews.apache.org/r/1146/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests passed
bq.
bq.
bq. Thanks,
bq.
bq. chinna
bq.
bq.
> In Task class and its subclasses logger is initialized in constructor
> ---------------------------------------------------------------------
>
> Key: HIVE-2183
> URL: https://issues.apache.org/jira/browse/HIVE-2183
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.5.0, 0.8.0
> Environment: Hadoop 0.20.1, Hive0.8.0 and SUSE Linux Enterprise
> Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5)
> Reporter: Chinna Rao Lalam
> Assignee: Chinna Rao Lalam
> Priority: Minor
> Attachments: HIVE-2183.1.patch, HIVE-2183.patch
>
>
> In Task class and its subclasses logger is initialized in constructor. Log
> object no need to initialize every time in the constructor, Log object can
> make it as static object.
> {noformat}
> Ex:
> public ExecDriver() {
> super();
> LOG = LogFactory.getLog(this.getClass().getName());
> console = new LogHelper(LOG);
> this.jobExecHelper = new HadoopJobExecHelper(job, console, this, this);
> }
> {noformat}
> Need to change like this
> {noformat}
> private static final Log LOG = LogFactory.getLog(ExecDriver.class);
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
