[ 
https://issues.apache.org/jira/browse/HIVE-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070807#comment-13070807
 ] 

jirapos...@reviews.apache.org commented on HIVE-2298:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1189/#review1181
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java
<https://reviews.apache.org/r/1189/#comment2483>

    Please fix the following checkstyle violations:
    
    Line 238: File contains tab characters (this is the first instance).
    Line 240: is longer than 100 characters.
    Line 245: '}' should be on the same line.


- Carl


On 2011-07-25 21:53:12, Carl Steinbach wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1189/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-25 21:53:12)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Review request for HIVE-2298.
bq.  
bq.  
bq.  This addresses bug HIVE-2298.
bq.      https://issues.apache.org/jira/browse/HIVE-2298
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ql/src/java/org/apache/hadoop/hive/ql/udf/UDAFPercentile.java 92db544 
bq.  
bq.  Diff: https://reviews.apache.org/r/1189/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Carl
bq.  
bq.



> Fix UDAFPercentile to tolerate null percentiles
> -----------------------------------------------
>
>                 Key: HIVE-2298
>                 URL: https://issues.apache.org/jira/browse/HIVE-2298
>             Project: Hive
>          Issue Type: Bug
>          Components: UDF
>    Affects Versions: 0.7.0
>            Reporter: Vaibhav Aggarwal
>            Assignee: Vaibhav Aggarwal
>         Attachments: HIVE-2298.patch
>
>
> UDAFPercentile when passed null percentile list will throw a null pointer 
> exception.
> Submitting a small fix for that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to