[
https://issues.apache.org/jira/browse/HIVE-2286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071315#comment-13071315
]
jirapos...@reviews.apache.org commented on HIVE-2286:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1137/#review1188
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/1137/#comment2597>
java.util.Stack is deprecated since it adds unnecessary synchronization.
We don't have a replacement yet (HIVE-1626) so we've just been using ArrayList.
Also, instead of typecasting to/from Object, use a static inner class for
holding the record of state variables.
- John
On 2011-07-25 23:03:22, Syed Albiz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1137/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-25 23:03:22)
bq.
bq.
bq. Review request for hive, John Sichi and Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Save the original HiveOperation/commandType when we generate the index
builder task and restore it after we're done generating the task so that the
authorization checks make the right decision when deciding what to do.
bq.
bq.
bq. This addresses bug HIVE-2286.
bq. https://issues.apache.org/jira/browse/HIVE-2286
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/java/org/apache/hadoop/hive/ql/Driver.java b278ffe
bq. ql/src/test/queries/clientpositive/index_auth.q PRE-CREATION
bq. ql/src/test/results/clientnegative/index_compact_entry_limit.q.out
fcb2673
bq. ql/src/test/results/clientnegative/index_compact_size_limit.q.out
fcb2673
bq. ql/src/test/results/clientpositive/index_auth.q.out PRE-CREATION
bq. ql/src/test/results/clientpositive/index_auto.q.out 8d65f98
bq. ql/src/test/results/clientpositive/index_auto_file_format.q.out 194b35e
bq. ql/src/test/results/clientpositive/index_auto_multiple.q.out 6b81fc3
bq. ql/src/test/results/clientpositive/index_auto_partitioned.q.out b0635db
bq. ql/src/test/results/clientpositive/index_auto_unused.q.out 3631bbc
bq. ql/src/test/results/clientpositive/index_bitmap.q.out 8f41ce3
bq. ql/src/test/results/clientpositive/index_bitmap1.q.out 9f638f5
bq. ql/src/test/results/clientpositive/index_bitmap2.q.out e901477
bq. ql/src/test/results/clientpositive/index_bitmap3.q.out 116c973
bq. ql/src/test/results/clientpositive/index_bitmap_auto.q.out cc9d91e
bq. ql/src/test/results/clientpositive/index_bitmap_auto_partitioned.q.out
9003eb4
bq. ql/src/test/results/clientpositive/index_bitmap_rc.q.out 9bd3c98
bq. ql/src/test/results/clientpositive/index_compact.q.out c339ec9
bq. ql/src/test/results/clientpositive/index_compact_1.q.out 34ba3ca
bq. ql/src/test/results/clientpositive/index_compact_2.q.out e8ce238
bq. ql/src/test/results/clientpositive/index_compact_3.q.out d39556d
bq. ql/src/test/results/clientpositive/index_creation.q.out 532f07e
bq.
bq. Diff: https://reviews.apache.org/r/1137/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added new testcase to TestCliDriver: index_auth.q
bq.
bq.
bq. Thanks,
bq.
bq. Syed
bq.
bq.
> ClassCastException when building index with security.authorization turned on
> ----------------------------------------------------------------------------
>
> Key: HIVE-2286
> URL: https://issues.apache.org/jira/browse/HIVE-2286
> Project: Hive
> Issue Type: Bug
> Reporter: Syed S. Albiz
> Assignee: Syed S. Albiz
> Attachments: HIVE-2286.1.patch, HIVE-2286.2.patch
>
>
> When trying to build an index with authorization checks turned on, hive
> issues the following ClassCastException:
> org.apache.hadoop.hive.ql.parse.DDLSemanticAnalyzer cannot be cast to
> org.apache.hadoop.hive.ql.parse.SemanticAnalyzer
> at
> org.apache.hadoop.hive.ql.Driver.doAuthorization(Driver.java:540)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:431)
> at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:335)
> at org.apache.hadoop.hive.ql.Driver.run(Driver.java:848)
> at
> org.apache.hadoop.hive.cli.CliDriver.processCmd(CliDriver.java:224)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:358)
> at
> org.apache.hadoop.hive.cli.CliDriver.processLine(CliDriver.java:293)
> at
> org.apache.hadoop.hive.cli.CliDriver.processReader(CliDriver.java:385)
> at
> org.apache.hadoop.hive.cli.CliDriver.processFile(CliDriver.java:392)
> at
> org.apache.hadoop.hive.cli.CliDriver.main(CliDriver.java:567)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.jav
> a:39)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessor
> Impl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at org.apache.hadoop.util.RunJar.main(RunJar.java:156)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
