[
https://issues.apache.org/jira/browse/HIVE-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072597#comment-13072597
]
jirapos...@reviews.apache.org commented on HIVE-2319:
-----------------------------------------------------
bq. On 2011-07-28 21:51:59, Paul Yang wrote:
bq. >
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java,
lines 232-233
bq. > <https://reviews.apache.org/r/1213/diff/2/?file=28094#file28094line232>
bq. >
bq. > Actually, we can't allow for a different ordering because that would
imply a different directory structure. We should just make sure that everything
but the comments are equal.
Ok cool, that cleans up the code quite a bit. The previous implementation only
checked if the partition key lists were of the same size, and one contained all
elements of the other. That is, it did not ensure ordering.
bq. On 2011-07-28 21:51:59, Paul Yang wrote:
bq. >
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java,
line 1036
bq. > <https://reviews.apache.org/r/1213/diff/2/?file=28095#file28095line1036>
bq. >
bq. > Message should say - it was able to change when it shouldn't have?
Fixed
- Sohan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1213/#review1215
-----------------------------------------------------------
On 2011-07-28 07:06:24, Sohan Jain wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1213/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-07-28 07:06:24)
bq.
bq.
bq. Review request for hive and Paul Yang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Altering a table's partition key comments raises an
InvalidOperationException. The partition key name and type should not be
mutable, but the comment should be able to get changed.
bq.
bq.
bq. This addresses bug HIVE-2319.
bq. https://issues.apache.org/jira/browse/HIVE-2319
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java
1151219
bq.
trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
1151219
bq.
bq. Diff: https://reviews.apache.org/r/1213/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added some test cases to HiveMetaStore that pass.
bq.
bq.
bq. Thanks,
bq.
bq. Sohan
bq.
bq.
> Calling alter_table after changing partition comment throws an exception
> ------------------------------------------------------------------------
>
> Key: HIVE-2319
> URL: https://issues.apache.org/jira/browse/HIVE-2319
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Sohan Jain
> Assignee: Sohan Jain
> Attachments: HIVE-2319.2.patch
>
>
> Altering a table's partition key comments raises an
> InvalidOperationException. The partition key name and type should not be
> mutable, but the comment should be able to get changed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
