[
https://issues.apache.org/jira/browse/HIVE-2303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072785#comment-13072785
]
jirapos...@reviews.apache.org commented on HIVE-2303:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1219/
-----------------------------------------------------------
Review request for hive.
Summary
-------
files with control-A,B are not delimited correctly.
This addresses bug HIVE-2303.
https://issues.apache.org/jira/browse/HIVE-2303
Diffs
-----
trunk/data/files/in7.txt PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 1151047
trunk/ql/src/test/queries/clientpositive/delimiter.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/combine2.q.out 1151047
trunk/ql/src/test/results/clientpositive/delimiter.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/filter_join_breaktask.q.out 1151047
trunk/ql/src/test/results/clientpositive/input23.q.out 1151047
trunk/ql/src/test/results/clientpositive/input42.q.out 1151047
trunk/ql/src/test/results/clientpositive/input_part7.q.out 1151047
trunk/ql/src/test/results/clientpositive/input_part9.q.out 1151047
trunk/ql/src/test/results/clientpositive/louter_join_ppr.q.out 1151047
trunk/ql/src/test/results/clientpositive/outer_join_ppr.q.out 1151047
trunk/ql/src/test/results/clientpositive/pcr.q.out 1151047
trunk/ql/src/test/results/clientpositive/rand_partitionpruner1.q.out 1151047
trunk/ql/src/test/results/clientpositive/rand_partitionpruner3.q.out 1151047
trunk/ql/src/test/results/clientpositive/regexp_extract.q.out 1151047
trunk/ql/src/test/results/clientpositive/router_join_ppr.q.out 1151047
trunk/ql/src/test/results/clientpositive/sample10.q.out 1151047
trunk/ql/src/test/results/clientpositive/sample6.q.out 1151047
trunk/ql/src/test/results/clientpositive/sample8.q.out 1151047
trunk/ql/src/test/results/clientpositive/sample9.q.out 1151047
trunk/ql/src/test/results/clientpositive/transform_ppr1.q.out 1151047
trunk/ql/src/test/results/clientpositive/transform_ppr2.q.out 1151047
trunk/ql/src/test/results/clientpositive/udf_explode.q.out 1151047
trunk/ql/src/test/results/clientpositive/udf_reflect.q.out 1151047
trunk/ql/src/test/results/clientpositive/udtf_explode.q.out 1151047
trunk/ql/src/test/results/clientpositive/union_ppr.q.out 1151047
trunk/ql/src/test/results/compiler/plan/cast1.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/groupby4.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/groupby5.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/groupby6.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/input20.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/input8.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/input_testxpath.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/input_testxpath2.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/join4.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/join5.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/join6.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/join7.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/join8.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/udf1.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/udf4.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/udf6.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/udf_case.q.xml 1151047
trunk/ql/src/test/results/compiler/plan/udf_when.q.xml 1151047
Diff: https://reviews.apache.org/r/1219/diff
Testing
-------
All tests passed with patch
Thanks,
Amareshwari
> files with control-A,B are not delimited correctly.
> ---------------------------------------------------
>
> Key: HIVE-2303
> URL: https://issues.apache.org/jira/browse/HIVE-2303
> Project: Hive
> Issue Type: Bug
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Attachments: patch-2303.txt
>
>
> The following is from one of our users:
>
> create external table impressions (imp string, msg string)
> row format delimited
> fields terminated by '\t'
> lines terminated by '\n'
> stored as textfile
> location '/xxx';
>
> Some strings in my data contains Control-A, Control-B etc as internal
> delimiters. If I do a
>
> Select * from impressions limit 10;
>
> All fields were able to print correctly. However if I do a
>
> Select * from impressions where msg regexp '.*' limit 10;
>
> The fields were broken by the control characters. The difference between the
> 2 commands is that the latter requires a map-reduce job.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
