----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1255/#review1265 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java <https://reviews.apache.org/r/1255/#comment2898> We're not actually generating a dummy file now... ql/src/test/queries/clientpositive/index_auto_test_if_used.q <https://reviews.apache.org/r/1255/#comment2900> Could you add a note that this test relies on the fact that we currently attempt to use indexes even when they are out of date, and that once we fix that by detecting stale indexes, we'll need another way to verify that the index actually had an effect? ql/src/test/queries/clientpositive/index_auto_test_if_used.q <https://reviews.apache.org/r/1255/#comment2899> Reissue query to demonstrate that results are returned after index lookup is disabled. - John On 2011-08-02 02:35:11, Syed Albiz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1255/ > ----------------------------------------------------------- > > (Updated 2011-08-02 02:35:11) > > > Review request for hive, John Sichi and Yongqiang He. > > > Summary > ------- > > return an empty array of input splits when we get back no results from the > hiveIndexResult > > > This addresses bug HIVE-2138. > https://issues.apache.org/jira/browse/HIVE-2138 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java > 1a1ecd7 > ql/src/test/queries/clientpositive/index_auto_test_if_used.q PRE-CREATION > ql/src/test/results/clientpositive/index_auto_test_if_used.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/1255/diff > > > Testing > ------- > > added index_auto_test_if_used.q to the test suite > > > Thanks, > > Syed > >
