[
https://issues.apache.org/jira/browse/HIVE-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078326#comment-13078326
]
jirapos...@reviews.apache.org commented on HIVE-2138:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1255/#review1265
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java
<https://reviews.apache.org/r/1255/#comment2898>
We're not actually generating a dummy file now...
ql/src/test/queries/clientpositive/index_auto_test_if_used.q
<https://reviews.apache.org/r/1255/#comment2900>
Could you add a note that this test relies on the fact that we currently
attempt to use indexes even when they are out of date, and that once we fix
that by detecting stale indexes, we'll need another way to verify that the
index actually had an effect?
ql/src/test/queries/clientpositive/index_auto_test_if_used.q
<https://reviews.apache.org/r/1255/#comment2899>
Reissue query to demonstrate that results are returned after index lookup
is disabled.
- John
On 2011-08-02 02:35:11, Syed Albiz wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1255/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-02 02:35:11)
bq.
bq.
bq. Review request for hive, John Sichi and Yongqiang He.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. return an empty array of input splits when we get back no results from the
hiveIndexResult
bq.
bq.
bq. This addresses bug HIVE-2138.
bq. https://issues.apache.org/jira/browse/HIVE-2138
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/java/org/apache/hadoop/hive/ql/index/HiveIndexedInputFormat.java
1a1ecd7
bq. ql/src/test/queries/clientpositive/index_auto_test_if_used.q
PRE-CREATION
bq. ql/src/test/results/clientpositive/index_auto_test_if_used.q.out
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/1255/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. added index_auto_test_if_used.q to the test suite
bq.
bq.
bq. Thanks,
bq.
bq. Syed
bq.
bq.
> Exception when no splits returned from index
> --------------------------------------------
>
> Key: HIVE-2138
> URL: https://issues.apache.org/jira/browse/HIVE-2138
> Project: Hive
> Issue Type: Bug
> Components: Indexing
> Affects Versions: 0.8.0
> Reporter: Russell Melick
> Assignee: Syed S. Albiz
> Attachments: HIVE-2138.1.patch, index_auto_test_if_used.q
>
>
> Running a query that uses indexing but doesn't return any results give an
> exception.
> {code} java.lang.IllegalArgumentException: Can not create a Path from an
> empty string
> at org.apache.hadoop.fs.Path.checkPathArg(Path.java:82)
> at org.apache.hadoop.fs.Path.<init>(Path.java:90)
> at org.apache.hadoop.util.StringUtils.stringToPath(StringUtils.java:224)
> at
> org.apache.hadoop.mapred.FileInputFormat.setInputPaths(FileInputFormat.java:282)
> at
> org.apache.hadoop.hive.ql.index.HiveIndexedInputFormat.getSplits(HiveIndexedInputFormat.java:123)
> {code}
> This could potentially be fixed by creating a new empty file to use for the
> splits.
> Once this is fixed, the index_auto_test_if_used.q can be used.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
