[ 
https://issues.apache.org/jira/browse/HIVE-2331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078366#comment-13078366
 ] 

jirapos...@reviews.apache.org commented on HIVE-2331:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1254/
-----------------------------------------------------------

(Updated 2011-08-02 18:58:32.937434)


Review request for hive and John Sichi.


Changes
-------

Regenerated the testcase outputs since they were mixed up previously.


Summary
-------

add a parameter to the hiveConf when generating the index query to ensure that 
the output is uncompressed


This addresses bug HIVE-2331.
    https://issues.apache.org/jira/browse/HIVE-2331


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/index/bitmap/BitmapIndexHandler.java 
c93c852 
  ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 
f4b7c15 
  ql/src/test/queries/clientpositive/index_bitmap_compression.q PRE-CREATION 
  ql/src/test/queries/clientpositive/index_compression.q PRE-CREATION 
  ql/src/test/results/clientpositive/index_bitmap_compression.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/index_compression.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1254/diff


Testing
-------

added index_compression.q and index_bitmap_compression.q to test both index 
handlers for this case.


Thanks,

Syed



> Turn off compression when generating index intermediate results
> ---------------------------------------------------------------
>
>                 Key: HIVE-2331
>                 URL: https://issues.apache.org/jira/browse/HIVE-2331
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Syed S. Albiz
>            Assignee: Syed S. Albiz
>         Attachments: HIVE-2331.1.patch, HIVE-2331.2.patch
>
>
> HiveIndexResult is not compression-aware, so for any index to work 
> (regardless of compact/bitmap) we need to not compress the index intermediate 
> file when we generate it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to