[
https://issues.apache.org/jira/browse/HIVE-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078541#comment-13078541
]
jirapos...@reviews.apache.org commented on HIVE-2171:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/790/#review1274
-----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
<https://reviews.apache.org/r/790/#comment2908>
Use curly brackets for all if statements (even when the body only has one
line). Use ant checkstyle to find more of these.
- John
On 2011-05-26 20:16:20, Jakob Homan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/790/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-05-26 20:16:20)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HIVE-2171: Allow custom serdes to set field comments
bq.
bq.
bq. This addresses bug HIVE-2171.
bq. https://issues.apache.org/jira/browse/HIVE-2171
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ivy/libraries.properties af856bd
bq. metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
c1fa4e5
bq. serde/ivy.xml d6c836a
bq.
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazyObjectInspectorFactory.java
4850601
bq.
serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/LazySimpleStructObjectInspector.java
e2fa9db
bq.
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryObjectInspectorFactory.java
2947e49
bq.
serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/objectinspector/LazyBinaryStructObjectInspector.java
3d5408f
bq.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ColumnarStructObjectInspector.java
66f4f8d
bq.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/MetadataListStructObjectInspector.java
bd42a0c
bq.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorFactory.java
90561a1
bq.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ReflectionStructObjectInspector.java
4a934c5
bq.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardStructObjectInspector.java
3b26e45
bq.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StructField.java
62c3017
bq.
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/UnionStructObjectInspector.java
76ff736
bq.
serde/src/test/org/apache/hadoop/hive/serde2/TestSerdeWithFieldComments.java
PRE-CREATION
bq.
serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestStandardObjectInspectors.java
f139ea5
bq.
bq. Diff: https://reviews.apache.org/r/790/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. New unit test and refactor existing unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Jakob
bq.
bq.
> Allow custom serdes to set field comments
> -----------------------------------------
>
> Key: HIVE-2171
> URL: https://issues.apache.org/jira/browse/HIVE-2171
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 0.7.0
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: HIVE-2171.patch
>
>
> Currently, while serde implementations can set a field's name, they can't set
> its comment. These are set in the metastore utils to {{(from
> deserializer)}}. For those serdes that can provide meaningful comments for a
> field, they should be propagated to the table description. These
> serde-provided comments could be prepended to "(from deserializer)" if others
> feel that's a meaningful distinction. This change involves updating
> {{StructField}} to support a (possibly null) comment field and then
> propagating this change out to the myriad places {{StructField}} is thrown
> around.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
