> On 2011-08-03 07:27:23, Ning Zhang wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 1387 > > <https://reviews.apache.org/r/1259/diff/1/?file=30272#file30272line1387> > > > > isn't the archive operation atomic? If an archive operation failed, and > > it's not recovered, does it mean the partitions will not be correct?
Yes, unfortunately, but it's how current versions of archive works. > On 2011-08-03 07:27:23, Ning Zhang wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 1081 > > <https://reviews.apache.org/r/1259/diff/1/?file=30272#file30272line1081> > > > > use Path.SEPARATOR instead of '/' It's used in URIs, which - according to specification - should use forward slashes. > On 2011-08-03 07:27:23, Ning Zhang wrote: > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java, line 1093 > > <https://reviews.apache.org/r/1259/diff/1/?file=30272#file30272line1093> > > > > '/' -> Path.SEPARATOR URIs - according to specification - should use forward slashes. - Marcin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1259/#review1275 ----------------------------------------------------------- On 2011-08-02 21:34:07, Marcin Kurczych wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1259/ > ----------------------------------------------------------- > > (Updated 2011-08-02 21:34:07) > > > Review request for hive, Paul Yang and namit jain. > > > Summary > ------- > > Allowing archiving at chosen level. When table is partitioned by ds, hr, min > it allows archiving at ds level, hr level and min level. Corresponding > syntaxes are: > ALTER TABLE test ARCHIVE PARTITION (ds='2008-04-08'); > ALTER TABLE test ARCHIVE PARTITION (ds='2008-04-08', hr='11'); > ALTER TABLE test ARCHIVE PARTITION (ds='2008-04-08', hr='11', min='30'); > > You cannot do much to archived partitions. You can read them. You cannot > write to them / overwrite them. You can drop single archived partitions, but > not parts of bigger archives. > > > Diffs > ----- > > trunk/data/conf/hive-site.xml 1153271 > trunk/metastore/if/hive_metastore.thrift 1153271 > trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.h 1153271 > trunk/metastore/src/gen/thrift/gen-cpp/hive_metastore_constants.cpp 1153271 > > trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java > 1153271 > > trunk/metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php > 1153271 > trunk/metastore/src/gen/thrift/gen-py/hive_metastore/constants.py 1153271 > trunk/metastore/src/gen/thrift/gen-rb/hive_metastore_constants.rb 1153271 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MetaUtils.java > PRE-CREATION > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1153271 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/UpdateArchivedCounter.java > PRE-CREATION > > trunk/ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 1153271 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1153271 > trunk/ql/src/test/queries/clientnegative/archive_insert1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert3.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_insert4.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi3.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi4.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi5.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi6.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_multi7.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec1.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec2.q PRE-CREATION > trunk/ql/src/test/queries/clientnegative/archive_partspec3.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/archive_corrupt.q PRE-CREATION > trunk/ql/src/test/queries/clientpositive/archive_multi.q PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive1.q.out 1153271 > trunk/ql/src/test/results/clientnegative/archive2.q.out 1153271 > trunk/ql/src/test/results/clientnegative/archive_insert1.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert2.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert3.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_insert4.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi1.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi2.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi3.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi4.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi5.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi6.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_multi7.q.out PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec1.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec2.q.out > PRE-CREATION > trunk/ql/src/test/results/clientnegative/archive_partspec3.q.out > PRE-CREATION > trunk/ql/src/test/results/clientpositive/archive_corrupt.q.out PRE-CREATION > trunk/ql/src/test/results/clientpositive/archive_multi.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/1259/diff > > > Testing > ------- > > Added unittests for normal uses. > Tried recovery during manual tests (had to simulate exceptions in different > places in code, which shouldn't be committed, that's why it had to be manual > testing). > > > Thanks, > > Marcin > >
