[
https://issues.apache.org/jira/browse/HIVE-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079200#comment-13079200
]
jirapos...@reviews.apache.org commented on HIVE-1735:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1256/#review1288
-----------------------------------------------------------
Ship it!
+1. Will commit if tests pass.
- Carl
On 2011-08-03 04:45:10, Amareshwari Sriramadasu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1256/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-03 04:45:10)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Changes from last patch:
bq.
bq. Re-based to trunk.
bq. Removed assert not null statements for list and map.
bq. Updated explode_null.q to test NULL values for map also.
bq.
bq.
bq. This addresses bug HIVE-1735.
bq. https://issues.apache.org/jira/browse/HIVE-1735
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFExplode.java
1151047
bq. trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported1.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported2.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported3.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/udtf_explode_not_supported4.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientpositive/explode_null.q 1151047
bq. trunk/ql/src/test/queries/clientpositive/udf_explode.q 1151047
bq. trunk/ql/src/test/queries/clientpositive/udtf_explode.q 1151047
bq.
trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported1.q.out
PRE-CREATION
bq.
trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported2.q.out
PRE-CREATION
bq.
trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported3.q.out
PRE-CREATION
bq.
trunk/ql/src/test/results/clientnegative/udtf_explode_not_supported4.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientpositive/explode_null.q.out 1151047
bq. trunk/ql/src/test/results/clientpositive/udf_explode.q.out 1151047
bq. trunk/ql/src/test/results/clientpositive/udtf_explode.q.out 1151047
bq.
bq. Diff: https://reviews.apache.org/r/1256/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All tests passed with the patch.
bq.
bq.
bq. Thanks,
bq.
bq. Amareshwari
bq.
bq.
> Extend Explode UDTF to handle Maps
> ----------------------------------
>
> Key: HIVE-1735
> URL: https://issues.apache.org/jira/browse/HIVE-1735
> Project: Hive
> Issue Type: New Feature
> Components: UDF
> Reporter: Carl Steinbach
> Assignee: Jonathan Natkins
> Fix For: 0.8.0
>
> Attachments: HIVE-1735.1.patch, HIVE-1735.2.patch.txt,
> HIVE-1735.2.patch.txt, HIVE-1735.3.patch.txt
>
>
> The explode() UDTF currently only accepts arrays as input. We should modify it
> so that it can also handle map inputs, in which case it will output two
> columns
> corresponding to the key and value fields.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
