> On 2011-08-05 20:38:11, Carl Steinbach wrote: > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java, line 235 > > <https://reviews.apache.org/r/1300/diff/1/?file=30859#file30859line235> > > > > Might want to consider using StringTokenizer or StreamTokenizer here.
This is how it was in the original code. All of this can actually be done quite a bit better. I'm happy to switch to tokenizer; the patch is a bit schizophrenic about refactoring/improving. I didn't change this since it's not directly related to what I was trying to test. > On 2011-08-05 20:38:11, Carl Steinbach wrote: > > cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java, line 37 > > <https://reviews.apache.org/r/1300/diff/1/?file=30860#file30860line37> > > > > There's already some very limited test coverage for the > > hive.cli.print.header feature in print_header.q. Why not extend this > > testcase instead of adding a new unit test? Because this is an actual unit test against a specific regression, which has value separate from the print_header.q integration test. I can add additional content to print_header.q, since this test is easier to identify what's gone wrong and runs in about 0.2 seconds, this one seems more useful. > On 2011-08-05 20:38:11, Carl Steinbach wrote: > > ivy/libraries.properties, line 47 > > <https://reviews.apache.org/r/1300/diff/1/?file=30861#file30861line47> > > > > We need to manage this dependency with Ivy. The Hive build currently > > runs against hadoop-0.20.1, which does not include mockito-all-1.8.2.jar I'm sorry; I don't understand. This is being brought in by Ivy? As part of HIVE-2171, I had mentioned we need to make sure testing related jars don't get included during binary/package, but that should be done in a different JIRA. > On 2011-08-05 20:38:11, Carl Steinbach wrote: > > cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java, line 1 > > <https://reviews.apache.org/r/1300/diff/1/?file=30860#file30860line1> > > > > cli/build.xml overrides the ant test target with a no-op, so this test > > is actually not getting run. I'll update cli/build.xml to not be a no-op, unless there's some reason to? - Jakob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1300/#review1308 ----------------------------------------------------------- On 2011-08-05 01:22:01, Jakob Homan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1300/ > ----------------------------------------------------------- > > (Updated 2011-08-05 01:22:01) > > > Review request for hive. > > > Summary > ------- > > Commands that don't return a schema cause NPE when print headers is on. > > > This addresses bug HIVE-2334. > https://issues.apache.org/jira/browse/HIVE-2334 > > > Diffs > ----- > > cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 9fa7bc6 > cli/src/test/org/apache/hadoop/hive/cli/TestCliDriverMethods.java > PRE-CREATION > ivy/libraries.properties af856bd > > Diff: https://reviews.apache.org/r/1300/diff > > > Testing > ------- > > New unit tests (both positive and negative) and verification on manual > cluster. > > > Thanks, > > Jakob > >
