----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1082/#review1316 -----------------------------------------------------------
Ship it! Will commit once tests pass. - Amareshwari On 2011-08-05 18:44:36, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1082/ > ----------------------------------------------------------- > > (Updated 2011-08-05 18:44:36) > > > Review request for hive. > > > Summary > ------- > > This patch adds map_keys(map) and map_values(map) UDFs. > > > This addresses bug HIVE-1734. > https://issues.apache.org/jira/browse/HIVE-1734 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 13584c1 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java > PRE-CREATION > ql/src/test/queries/clientnegative/udf_map_keys_arg_num.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_map_keys_arg_type.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_map_values_arg_num.q PRE-CREATION > ql/src/test/queries/clientnegative/udf_map_values_arg_type.q PRE-CREATION > ql/src/test/queries/clientpositive/udf_map_keys.q PRE-CREATION > ql/src/test/queries/clientpositive/udf_map_values.q PRE-CREATION > ql/src/test/results/clientnegative/udf_map_keys_arg_num.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_map_keys_arg_type.q.out PRE-CREATION > ql/src/test/results/clientnegative/udf_map_values_arg_num.q.out > PRE-CREATION > ql/src/test/results/clientnegative/udf_map_values_arg_type.q.out > PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out d4f6c98 > ql/src/test/results/clientpositive/udf_map_keys.q.out PRE-CREATION > ql/src/test/results/clientpositive/udf_map_values.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/1082/diff > > > Testing > ------- > > > Thanks, > > Carl > >
