[ https://issues.apache.org/jira/browse/HIVE-2344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081567#comment-13081567 ]
jirapos...@reviews.apache.org commented on HIVE-2344: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1404/ ----------------------------------------------------------- Review request for hive, John Sichi and Yongqiang He. Summary ------- Any filter on 'udf selected as column alias in select' will be pushed down through the select operator, which it should not. Patch addresses this by walking through the udf expression again. This addresses bug HIVE-2344. https://issues.apache.org/jira/browse/HIVE-2344 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java 1153812 trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1153812 trunk/ql/src/test/queries/clientpositive/ppd_udf_col.q PRE-CREATION trunk/ql/src/test/results/clientpositive/ppd_udf_col.q.out PRE-CREATION Diff: https://reviews.apache.org/r/1404/diff Testing ------- Thanks, Amareshwari > filter is removed due to regression of HIVE-1538 > ------------------------------------------------ > > Key: HIVE-2344 > URL: https://issues.apache.org/jira/browse/HIVE-2344 > Project: Hive > Issue Type: Bug > Reporter: He Yongqiang > Assignee: Amareshwari Sriramadasu > Attachments: hive-patch-2344.txt, ppd_udf_col.q.out.txt > > > select * from > ( > select type_bucket,randum123 > from (SELECT *, cast(rand() as double) AS randum123 FROM tbl where ds = ...) > a > where randum123 <=0.1)s where s.randum123>0.1 limit 20; > This is returning results... > and > explain > select type_bucket,randum123 > from (SELECT *, cast(rand() as double) AS randum123 FROM tbl where ds = ...) > a > where randum123 <=0.1 > shows that there is no filter. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira