----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1295/#review1364 -----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/1295/#comment3082> As a convention, we should declare the variable as interface (List in this case) rather than implementation (ArrayList). trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java <https://reviews.apache.org/r/1295/#comment3086> comments are not correct: post execution --> failure - Ning On 2011-08-04 19:06:43, Kevin Wilfong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1295/ > ----------------------------------------------------------- > > (Updated 2011-08-04 19:06:43) > > > Review request for hive and Ning Zhang. > > > Summary > ------- > > I added a new type of hook, which will be run when a job fails. > > > This addresses bug HIVE-2346. > https://issues.apache.org/jira/browse/HIVE-2346 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1153966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1153966 > trunk/ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 1153966 > > Diff: https://reviews.apache.org/r/1295/diff > > > Testing > ------- > > I ran the TestCliDriver and TestNegativeCliDriver test suites and verified > they passed. > > In addition, I created a sample hook, which simply logged that it was run. I > verified it was run on a failure, but not when a job succeeded. > > > Thanks, > > Kevin > >
