[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082127#comment-13082127 ]
jirapos...@reviews.apache.org commented on HIVE-2310: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1444/ ----------------------------------------------------------- Review request for John Sichi and Carl Steinbach. Summary ------- -Require the user to specify a valid LOCATION clause for CREATE EXTERNAL TABLE statements (except non-native tables). -Throw an error if the user specifies a LOCATION that is a subdirectory of hive.metastore.warehouse.dir This addresses bug hive-2310. https://issues.apache.org/jira/browse/hive-2310 Diffs ----- trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1155176 trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1155176 trunk/ql/src/test/queries/clientnegative/create_external.q PRE-CREATION trunk/ql/src/test/queries/clientnegative/external2.q 1155176 trunk/ql/src/test/queries/clientpositive/alter2.q 1155176 trunk/ql/src/test/queries/clientpositive/create_like.q 1155176 trunk/ql/src/test/queries/clientpositive/create_like_view.q 1155176 trunk/ql/src/test/results/clientnegative/create_external.q.out PRE-CREATION trunk/ql/src/test/results/clientnegative/external2.q.out 1155176 trunk/ql/src/test/results/clientpositive/alter2.q.out 1155176 trunk/ql/src/test/results/clientpositive/create_like.q.out 1155176 trunk/ql/src/test/results/clientpositive/create_like_view.q.out 1155176 Diff: https://reviews.apache.org/r/1444/diff Testing ------- unit tests pass Thanks, Franklin > CREATE EXTERNAL TABLE should require a valid LOCATION clause > ------------------------------------------------------------ > > Key: HIVE-2310 > URL: https://issues.apache.org/jira/browse/HIVE-2310 > Project: Hive > Issue Type: Bug > Components: SQL > Reporter: Carl Steinbach > Assignee: Franklin Hu > Fix For: 0.8.0 > > Attachments: hive-2310.1.patch > > -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira