[
https://issues.apache.org/jira/browse/HIVE-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082697#comment-13082697
]
[email protected] commented on HIVE-2358:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1459/
-----------------------------------------------------------
Review request for hive and Carl Steinbach.
Summary
-------
make the returned values consistent.
This addresses bug HIVE-2358.
https://issues.apache.org/jira/browse/HIVE-2358
Diffs
-----
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveResultSetMetaData.java 2aa7727
jdbc/src/java/org/apache/hadoop/hive/jdbc/JdbcColumn.java 43cc2a3
jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java d72cf43
Diff: https://reviews.apache.org/r/1459/diff
Testing
-------
added new unit tests
Thanks,
Patrick
> JDBC DatabaseMetaData and ResultSetMetaData need to match for particular types
> ------------------------------------------------------------------------------
>
> Key: HIVE-2358
> URL: https://issues.apache.org/jira/browse/HIVE-2358
> Project: Hive
> Issue Type: Bug
> Components: JDBC
> Affects Versions: 0.8.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 0.8.0
>
> Attachments: HIVE-2358.patch
>
>
> My patch for HIVE-1631 did not ensure the following (from comment on 1631):
> -------------
> Mythili Gopalakrishnan added a comment - 08/Aug/11 08:42
> Just tested this fix and does NOT work correctly. Here are my findings on a
> FLOAT column
> Without Patch on a FLOAT Column
> --------------------------------
> DatabaseMetaData.getColumns () COLUMN_SIZE returns 12
> DatabaseMetaData.getColumns () DECIMAL_DIGITS - returns 0
> ResultSetMetaData.getPrecision() returns 0
> ResultSetMetaData.getScale() returns 0
> With Patch on a FLOAT Column
> ----------------------------
> DatabaseMetaData.getColumns () COLUMN_SIZE returns 24
> DatabaseMetaData.getColumns () DECIMAL_DIGITS - returns 0
> ResultSetMetaData.getPrecision() returns 7
> ResultSetMetaData.getScale() returns 7
> Also both DatabaseMetadata and ResultSetMetaData must return the same
> information for Precision and Scale for FLOAT,DOUBLE types.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
