----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1481/#review1444 -----------------------------------------------------------
trunk/data/conf/hive-site.xml <https://reviews.apache.org/r/1481/#comment3342> This overrides the value set in hive-default.xml. And also deviates from the existing behavior. So, the property needn't be mentioned in hive-site.xml trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java <https://reviews.apache.org/r/1481/#comment3343> Why create a reference, when the same can be logged directly and easily readable as well. trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java <https://reviews.apache.org/r/1481/#comment3344> There needs to be a test case to test the other use-case also, where the user would have chosen not to set the property to "true". - M On 2011-08-12 19:10:40, chinna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1481/ > ----------------------------------------------------------- > > (Updated 2011-08-12 19:10:40) > > > Review request for hive. > > > Summary > ------- > > Now queries leaves the map outputs under scratch.dir after execution. If the > hive server is stopped we need not keep the stopped server's map oputputs. So > whle starting the server we can clear the scratch.dir. This can help in > improved disk usage. > > Implemented a cleanup method in HiveServer and it will trigger based on the > property value "hive.start.cleanup.scrachdir" > > > This addresses bug HIVE-2181. > https://issues.apache.org/jira/browse/HIVE-2181 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1156493 > trunk/conf/hive-default.xml 1156493 > trunk/data/conf/hive-site.xml 1156493 > trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java > 1156493 > trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java > 1156493 > > Diff: https://reviews.apache.org/r/1481/diff > > > Testing > ------- > > Added test case for this scenario. > > > Thanks, > > chinna > >
