[
https://issues.apache.org/jira/browse/HIVE-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084620#comment-13084620
]
jirapos...@reviews.apache.org commented on HIVE-2181:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1481/#review1444
-----------------------------------------------------------
trunk/data/conf/hive-site.xml
<https://reviews.apache.org/r/1481/#comment3342>
This overrides the value set in hive-default.xml. And also deviates from
the existing behavior. So, the property needn't be mentioned in hive-site.xml
trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java
<https://reviews.apache.org/r/1481/#comment3343>
Why create a reference, when the same can be logged directly and easily
readable as well.
trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java
<https://reviews.apache.org/r/1481/#comment3344>
There needs to be a test case to test the other use-case also, where the
user would have chosen not to set the property to "true".
- M
On 2011-08-12 19:10:40, chinna wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1481/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-12 19:10:40)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Now queries leaves the map outputs under scratch.dir after execution. If
the hive server is stopped we need not keep the stopped server's map oputputs.
So whle starting the server we can clear the scratch.dir. This can help in
improved disk usage.
bq.
bq. Implemented a cleanup method in HiveServer and it will trigger based on
the property value "hive.start.cleanup.scrachdir"
bq.
bq.
bq. This addresses bug HIVE-2181.
bq. https://issues.apache.org/jira/browse/HIVE-2181
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1156493
bq. trunk/conf/hive-default.xml 1156493
bq. trunk/data/conf/hive-site.xml 1156493
bq. trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java
1156493
bq.
trunk/service/src/test/org/apache/hadoop/hive/service/TestHiveServer.java
1156493
bq.
bq. Diff: https://reviews.apache.org/r/1481/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added test case for this scenario.
bq.
bq.
bq. Thanks,
bq.
bq. chinna
bq.
bq.
> Clean up the scratch.dir (tmp/hive-root) while restarting Hive server.
> ------------------------------------------------------------------------
>
> Key: HIVE-2181
> URL: https://issues.apache.org/jira/browse/HIVE-2181
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.8.0
> Environment: Suse linux, Hadoop 20.1, Hive 0.8
> Reporter: sanoj mathew
> Assignee: Chinna Rao Lalam
> Priority: Minor
> Attachments: HIVE-2181.1.patch, HIVE-2181.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Now queries leaves the map outputs under scratch.dir after execution. If the
> hive server is stopped we need not keep the stopped server's map oputputs. So
> whle starting the server we can clear the scratch.dir. This can help in
> improved disk usage.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
