----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1423/#review1451 -----------------------------------------------------------
>> The below configurations are not used in the code base but these >> configurations are required for the system so need to maintain in the >> hive-default.xml and no need to add in the HiveConf.java Actually, everything that appears in hive-default.xml should also appear in HiveConf and vice-versa. - Carl On 2011-08-09 19:11:13, chinna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1423/ > ----------------------------------------------------------- > > (Updated 2011-08-09 19:11:13) > > > Review request for hive, Carl Steinbach and John Sichi. > > > Summary > ------- > > The below configurations are not used in the code base so removed from the > hive-default.xml > > hive.mapjoin.hashtable.initialCapacity > hive.mapjoin.hashtable.loadfactor > hive.mapjoin.smalltable.filesize > hive.optimize.pruner > hive.stats.jdbc.atomic > hive.concurrency.manager > > The below configurations are not used in the code base but these > configurations are required for the system so need to maintain in the > hive-default.xml and no need to add in the HiveConf.java > > javax.jdo.option.ConnectionDriverName > javax.jdo.PersistenceManagerFactoryClass > javax.jdo.option.DetachAllOnCommit > javax.jdo.option.NonTransactionalRead > javax.jdo.option.ConnectionUserName > fs.har.impl > > > This addresses bug HIVE-2196. > https://issues.apache.org/jira/browse/HIVE-2196 > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1155275 > trunk/conf/hive-default.xml 1155275 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1155275 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > 1155275 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMarkPartitionRemote.java > 1155275 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreAuthorization.java > 1155275 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java > 1155275 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestRemoteHiveMetaStore.java > 1155275 > > trunk/shims/src/common/java/org/apache/hadoop/hive/io/HiveIOExceptionHandlerChain.java > 1155275 > > trunk/shims/src/test/org/apache/hadoop/hive/thrift/TestHadoop20SAuthBridge.java > 1155275 > > Diff: https://reviews.apache.org/r/1423/diff > > > Testing > ------- > > All unit tests passed > > > Thanks, > > chinna > >
