[
https://issues.apache.org/jira/browse/HIVE-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088100#comment-13088100
]
jirapos...@reviews.apache.org commented on HIVE-2020:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1607/
-----------------------------------------------------------
Review request for hive and Carl Steinbach.
Summary
-------
1. Added support hivevar
2. Removed dependency on new class
3. Added test case
This addresses bug HIVE-2020.
https://issues.apache.org/jira/browse/HIVE-2020
Diffs
-----
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a2976b5
cli/src/java/org/apache/hadoop/hive/cli/OptionsProcessor.java 90084ed
ql/src/java/org/apache/hadoop/hive/ql/parse/VariableSubstitution.java e203dda
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 97fa1ab
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6a6e8e8
ql/src/test/queries/clientpositive/set_variable_sub.q PRE-CREATION
ql/src/test/results/clientpositive/set_variable_sub.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1607/diff
Testing
-------
Thanks,
Vaibhav
> Create a separate namespace for Hive variables
> ----------------------------------------------
>
> Key: HIVE-2020
> URL: https://issues.apache.org/jira/browse/HIVE-2020
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Vaibhav Aggarwal
> Attachments: HIVE-2020-2.patch, HIVE-2020-3.patch, HIVE-2020.patch
>
>
> Support for variable substitution was added in HIVE-1096. However, variable
> substitution was implemented by reusing the HiveConf namespace, so there is
> no separation between Hive configuration properties and Hive variables.
> This ticket encompasses the following enhancements:
> * Create a separate namespace for managing Hive variables.
> * Add support for setting variables on the command line via '-hivevar x=y'
> * Add support for setting variables through the CLI via 'var x=y'
> * Add support for referencing variables in statements using either
> '${hivevar:var_name}' or '${var_name}'
> * Provide a means for differentiating between hiveconf, hivevar, system, and
> environment properties in the output of 'set -v'
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
