[
https://issues.apache.org/jira/browse/HIVE-2415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093498#comment-13093498
]
jirapos...@reviews.apache.org commented on HIVE-2415:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1672/#review1686
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java
<https://reviews.apache.org/r/1672/#comment3842>
remove TAB
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/1672/#comment3844>
tab
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/1672/#comment3843>
tab
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/1672/#comment3845>
does this metastore object change causes the mapped DB table change? it
looks dangerous here.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/1672/#comment3846>
why we need to clear deserializer here? Is it to make sure column names are
not from deserializer?
- Ning
On 2011-08-28 23:14:12, Yongqiang He wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1672/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-28 23:14:12)
bq.
bq.
bq. Review request for hive and Ning Zhang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. move validation of renaming/replacing columns from runtime to parser
bq.
bq.
bq. This addresses bug HIVE-2415.
bq. https://issues.apache.org/jira/browse/HIVE-2415
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1162190
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 1162190
bq.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
1162190
bq. trunk/ql/src/test/queries/clientnegative/replace_columns.q PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/replace_columns_2.q
PRE-CREATION
bq. trunk/ql/src/test/queries/clientnegative/replace_columns_3.q
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/altern1.q.out 1162190
bq. trunk/ql/src/test/results/clientnegative/column_rename1.q.out 1162190
bq. trunk/ql/src/test/results/clientnegative/column_rename2.q.out 1162190
bq. trunk/ql/src/test/results/clientnegative/column_rename4.q.out 1162190
bq. trunk/ql/src/test/results/clientnegative/replace_columns.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/replace_columns_2.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/replace_columns_3.q.out
PRE-CREATION
bq. trunk/ql/src/test/results/clientnegative/replace_columns_4.q.out
PRE-CREATION
bq. trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
1162190
bq.
bq. Diff: https://reviews.apache.org/r/1672/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Yongqiang
bq.
bq.
> disallow partition column names when doing replace columns
> ----------------------------------------------------------
>
> Key: HIVE-2415
> URL: https://issues.apache.org/jira/browse/HIVE-2415
> Project: Hive
> Issue Type: Bug
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-2415.1.patch
>
>
> alter table replace columns allows to add a column with the same name as
> partition column, which introduced inconsistency.
> We should disallow this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
