----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1700/#review1731 -----------------------------------------------------------
jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java <https://reviews.apache.org/r/1700/#comment3948> Please Add a negative testcase that exercises this exception. jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java <https://reviews.apache.org/r/1700/#comment3947> Please add a new testcase or add to an existing testcase instead of modifying a pre-existing testcase. You have provided test coverage for PreparedStatement.setObject() at the expense of removing test coverage for PreparedStatement.setBoolean()/setInt(),etc. - Carl On 2011-09-02 01:35:33, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1700/ > ----------------------------------------------------------- > > (Updated 2011-09-02 01:35:33) > > > Review request for hive. > > > Summary > ------- > > Review for HIVE-2304 (Ido Hadanny) > > > This addresses bug HIVE-2304. > https://issues.apache.org/jira/browse/HIVE-2304 > > > Diffs > ----- > > jdbc/src/java/org/apache/hadoop/hive/jdbc/HivePreparedStatement.java > 679792c > jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11 > > Diff: https://reviews.apache.org/r/1700/diff > > > Testing > ------- > > > Thanks, > > Carl > >
