[
https://issues.apache.org/jira/browse/HIVE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099914#comment-13099914
] jirapos...@reviews.apache.org commented on HIVE-2416: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1741/ ----------------------------------------------------------- (Updated 2011-09-08 04:52:29.083703) Review request for hive and Amareshwari Sriramadasu. Changes ------- Update BUGs field to link JIRA Summary ------- Currently when multiple distinct function is used, hive.groupby.skewindata optimization parameter shall be set false, or else an exception is raised: Error in semantic analysis: DISTINCT on different columns not supported with skew in data Skew groupby should support multiple distinct function This addresses bug HIVE-2416. https://issues.apache.org/jira/browse/HIVE-2416 Diffs ----- http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ReduceSinkDesc.java 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/groupby2_map_skew_multi_distinct.q 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientnegative/groupby3_multi_distinct.q 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/groupby2_map_skew_multi_distinct.q PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/groupby2_map_skew_multi_distinct.q.out 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/groupby3_map_skew_multi_distinct.q.out 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientnegative/groupby3_multi_distinct.q.out 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/groupby2.q.out 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/groupby2_map_skew.q.out 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/groupby2_map_skew_multi_distinct.q.out PRE-CREATION http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/groupby3.q.out 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/groupby3_map_skew.q.out 1162620 http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/nullgroup4.q.out 1162620 Diff: https://reviews.apache.org/r/1741/diff Testing ------- All UT passed Thanks, Ted > Multiple distinct function to support hive.groupby.skewindata optimization > -------------------------------------------------------------------------- > > Key: HIVE-2416 > URL: https://issues.apache.org/jira/browse/HIVE-2416 > Project: Hive > Issue Type: Improvement > Reporter: Ted Xu > Assignee: Ted Xu > Attachments: multi_distinct_skew.patch > > > Currently when multiple distinct function is used, hive.groupby.skewindata > optimization parameter shall be set false, or else an exception is raised: > {code} > Error in semantic analysis: DISTINCT on different columns not supported with > skew in data > {code} > Skew groupby should support multiple distinct function -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
