-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28372/
-----------------------------------------------------------
(Updated Dec. 10, 2014, 8:34 p.m.)
Review request for hive.
Changes
-------
Address review comments.
Bugs: HIVE-8950
https://issues.apache.org/jira/browse/HIVE-8950
Repository: hive-git
Description
-------
HIVE-8950: Add support in ParquetHiveSerde to create table schema from a
parquet file
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
fafd78e63e9b41c9fdb0e017b567dc719d151784
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
32186391e7e4cfc9b4d06d7376663e82ec08d9e6
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
b137fcb86e27ac91ed3c733b4d8788228d379a09
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
2db2658fbc57fba01c892c9213baef6c498e659b
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ParquetSchemaReader.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/convert/ParquetToHiveSchemaConverter.java
PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java
4effe736fcf9d3715f03eed9885c299a7aa040dd
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
cd3d349e8bd8785d6cadaf9ed8fa7598f223774a
ql/src/test/queries/clientpositive/parquet_array_of_multi_field_struct_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_array_of_optional_elements_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_array_of_required_elements_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_array_of_single_field_struct_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_array_of_structs_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_array_of_structs_gen_schema_ext.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_array_of_unannotated_groups_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_array_of_unannotated_primitives_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_avro_array_of_primitives_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_avro_array_of_single_field_struct_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_decimal_gen_schema.q PRE-CREATION
ql/src/test/queries/clientpositive/parquet_thrift_array_of_primitives_gen_schema.q
PRE-CREATION
ql/src/test/queries/clientpositive/parquet_thrift_array_of_single_field_struct_gen_schema.q
PRE-CREATION
ql/src/test/results/clientpositive/create_view_partitioned.q.out
ebf9a6bc4f2321d7f539b7a445b3f279e3285b8a
ql/src/test/results/clientpositive/parquet_array_of_multi_field_struct_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_array_of_optional_elements_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_array_of_required_elements_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_array_of_single_field_struct_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_array_of_structs_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_array_of_structs_gen_schema_ext.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_array_of_unannotated_groups_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_array_of_unannotated_primitives_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_avro_array_of_primitives_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_avro_array_of_single_field_struct_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_decimal_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_thrift_array_of_primitives_gen_schema.q.out
PRE-CREATION
ql/src/test/results/clientpositive/parquet_thrift_array_of_single_field_struct_gen_schema.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/28372/diff/
Testing
-------
Tested by adding appropriate qTests.
Thanks,
Ashish Singh
