----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28964/#review64785 -----------------------------------------------------------
Hi, This is absolutely awesome! Your code is very clean and cuts right to the heard of the issue. I am seriously impressed! I have a few minor items we should discuss but again I *love* this... ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveStoragePerformance.java <https://reviews.apache.org/r/28964/#comment107552> Since we don't actually use the data, should we just re-use the same value? That way we won't get the noise of allocating memory for new objects? ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveStoragePerformance.java <https://reviews.apache.org/r/28964/#comment107550> we should add a default case which throws an exception ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveStoragePerformance.java <https://reviews.apache.org/r/28964/#comment107551> Since we don't care about the data output, would it be useful to write to a file, thus we could write to /dev/null? The reason I mention this is writing to a file will encounter disk overhread but if we write to /dev/null we'll purely be testing code paths. - Brock Noland On Dec. 11, 2014, 7:48 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28964/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 7:48 p.m.) > > > Review request for hive. > > > Bugs: HIVE-8121 > https://issues.apache.org/jira/browse/HIVE-8121 > > > Repository: hive-git > > > Description > ------- > > This is a new tool used to test ORC & PARQUET file format performance. > > > Diffs > ----- > > ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveStoragePerformance.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28964/diff/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
