----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28933/#review64857 -----------------------------------------------------------
Looks good! I left some minor comments below. data/files/avro_timestamp.txt <https://reviews.apache.org/r/28933/#comment107655> how about add some other formats? serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java <https://reviews.apache.org/r/28933/#comment107656> It is consistent in the code to use "Schema.Type.Long". Then the import is not necessary. serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java <https://reviews.apache.org/r/28933/#comment107657> We check TypeInfo -> Schema here. Can we also check Schema -> TypeInfo ? - Dong Chen On Dec. 11, 2014, 5:57 a.m., cheng xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28933/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 5:57 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > The patch includes: > 1.add timestamp support for AvroSerde > 2.add related test cases > > > Diffs > ----- > > data/files/avro_timestamp.txt PRE-CREATION > ql/src/test/queries/clientpositive/avro_timestamp.q PRE-CREATION > ql/src/test/results/clientpositive/avro_timestamp.q.out PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java > 07c5ecf > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerDe.java 7639a2b > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java > c8eac89 > serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java > c84b1a0 > serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java > 8cb2dc3 > serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java > cd5a0fa > > Diff: https://reviews.apache.org/r/28933/diff/ > > > Testing > ------- > > Test passed for added cases > > > Thanks, > > cheng xu > >
