[ 
https://issues.apache.org/jira/browse/HIVE-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257218#comment-14257218
 ] 

Brock Noland commented on HIVE-9161:
------------------------------------

Hi [~spena],

This looks good to me! I did note one thing related the comments. I believe 
[~mohitsabharwal] was suggesting we put the doc comment in the places where we 
change a {{HashMap}} to {{LinkedHashMap}} and {{HashSet}} to {{LinkedHashSet}} 
as the {{Linked}} versions are the ones which give us deterministic order. Thus 
I think we can remove the statements in {{StandardMapObjctInspector}} and add 
the comments to the other classes.

Thank you!

> Fix ordering differences on UDF functions due to Java8
> ------------------------------------------------------
>
>                 Key: HIVE-9161
>                 URL: https://issues.apache.org/jira/browse/HIVE-9161
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 0.13.1
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>         Attachments: HIVE-9161.1.patch, HIVE-9161.2.patch, HIVE-9161.3.patch
>
>
> Java 8 uses a different hash function for HashMap, which is leading to 
> iteration order differences in several cases. (See Java8 vs Java7)
> This part is related to UDF functions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to