----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29635/#review67252 -----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java <https://reviews.apache.org/r/29635/#comment111254> I think this needs to get called even if super.close throws an exception. - Thejas Nair On Jan. 6, 2015, 7:28 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29635/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2015, 7:28 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-9234 > https://issues.apache.org/jira/browse/HIVE-9234 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-9234 > > > Diffs > ----- > > service/src/java/org/apache/hive/service/cli/session/HiveSession.java > 6359a5b > service/src/java/org/apache/hive/service/cli/session/HiveSessionBase.java > 50094d2 > service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java > cabf32a > > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java > 7acd113 > service/src/java/org/apache/hive/service/cli/session/SessionManager.java > 137359b > > Diff: https://reviews.apache.org/r/29635/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >