[ https://issues.apache.org/jira/browse/HIVE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277218#comment-14277218 ]
Sergio Peña commented on HIVE-9356: ----------------------------------- Hi [~dongc] Aren't we going to have issues in the future because this is finding commands that are not for testing only? if (HiveCommand.find(oneCmd.trim().split("\\s+")) != null) { What if we create another flag to find ALL commands? Something like this: if (HiveCommand.find(oneCmd.trim().split("\\s+"), HiveCommand.ALL) != null) { > Fail to handle the case that a qfile contains a semicolon in the annotation > --------------------------------------------------------------------------- > > Key: HIVE-9356 > URL: https://issues.apache.org/jira/browse/HIVE-9356 > Project: Hive > Issue Type: Sub-task > Affects Versions: encryption-branch > Reporter: Ferdinand Xu > Assignee: Dong Chen > Fix For: encryption-branch > > Attachments: HIVE-9356-encryption.patch, > HIVE-9356.1-encryption.patch, HIVE-9356.patch > > > Currently, we split the qfile by the semicolon. It should be able to handle > the comment statement in the qfile with a semicolon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)