> On Ene. 15, 2015, 7:47 a.m., Dong Chen wrote: > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java, > > line 355 > > <https://reviews.apache.org/r/28964/diff/4/?file=822007#file822007line355> > > > > OrcRecordWriter load its internal writer lazily, which means writing > > the first record is different with writing following records. > > > > Should we consider this when defining and evaluating benchmark?
Thanks for the tip. The write test now calls the write() method with many rows intead. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28964/#review68215 ----------------------------------------------------------- On Ene. 14, 2015, 11:48 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28964/ > ----------------------------------------------------------- > > (Updated Ene. 14, 2015, 11:48 p.m.) > > > Review request for hive, Brock Noland and cheng xu. > > > Bugs: HIVE-8121 > https://issues.apache.org/jira/browse/HIVE-8121 > > > Repository: hive-git > > > Description > ------- > > This is a new tool used to test ORC & PARQUET file format performance. > > > Diffs > ----- > > itests/hive-jmh/pom.xml PRE-CREATION > > itests/hive-jmh/src/main/java/org/apache/hive/benchmark/storage/ColumnarStorageBench.java > PRE-CREATION > itests/pom.xml 40e7b9b8114d693f352f28ad94e6abcf96d1372a > > Diff: https://reviews.apache.org/r/28964/diff/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
