-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28797/#review69217
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
<https://reviews.apache.org/r/28797/#comment113834>

    Could set be ever null? if it is then there can be only single select 
statement right? if so won't it be covered by selectStatement?


- John Pullokkaran


On Jan. 19, 2015, 9:59 p.m., pengcheng xiong wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28797/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 9:59 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Current version (Hive 0.14) does not support union (or union distinct). It 
> only supports union all. In this patch, we try to add this new feature by 
> rewriting union distinct to union all followed by group by.
> 
> 
> Diffs
> -----
> 
>   itests/src/test/resources/testconfiguration.properties 43c2d56 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java
>  95ad9e0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 9c7603c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g c960a6b 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5ff9552 
>   ql/src/test/queries/clientnegative/unionClusterBy.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/unionDistributeBy.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/unionLimit.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/unionOrderBy.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/unionSortBy.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/cbo_union.q e9508c5 
>   ql/src/test/queries/clientpositive/explode_null.q 76e4535 
>   ql/src/test/queries/clientpositive/input25.q e48368f 
>   ql/src/test/queries/clientpositive/input26.q 642a7db 
>   ql/src/test/queries/clientpositive/load_dyn_part14.q c34c3bf 
>   ql/src/test/queries/clientpositive/metadataOnlyOptimizer.q a26ef1a 
>   ql/src/test/queries/clientpositive/script_env_var1.q 381c5dc 
>   ql/src/test/queries/clientpositive/script_env_var2.q 5f10812 
>   ql/src/test/queries/clientpositive/union3.q d402cb0 
>   ql/src/test/queries/clientpositive/unionDistinct_1.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/unionDistinct_2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/union_null.q 64e1672 
>   ql/src/test/queries/clientpositive/union_remove_25.q c6c09e1 
>   ql/src/test/queries/clientpositive/union_top_level.q 946473a 
>   ql/src/test/queries/clientpositive/vector_multi_insert.q 77404e9 
>   ql/src/test/results/clientnegative/unionClusterBy.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/unionDistributeBy.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/unionLimit.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/unionOrderBy.q.out PRE-CREATION 
>   ql/src/test/results/clientnegative/unionSortBy.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/ba_table_union.q.out 706a537 
>   ql/src/test/results/clientpositive/cbo_union.q.out 1fd88ec 
>   ql/src/test/results/clientpositive/char_union1.q.out bdc4a1d 
>   ql/src/test/results/clientpositive/explain_logical.q.out 2e73a89 
>   ql/src/test/results/clientpositive/explode_null.q.out db71c69 
>   ql/src/test/results/clientpositive/groupby_sort_1_23.q.out dd450cb 
>   ql/src/test/results/clientpositive/groupby_sort_skew_1_23.q.out 2f08999 
>   ql/src/test/results/clientpositive/input25.q.out 141a576 
>   ql/src/test/results/clientpositive/input26.q.out 66d3bd2 
>   ql/src/test/results/clientpositive/input_part7.q.out 6094f9c 
>   ql/src/test/results/clientpositive/join34.q.out a20e49f 
>   ql/src/test/results/clientpositive/join35.q.out 937539c 
>   ql/src/test/results/clientpositive/load_dyn_part14.q.out a9dde4d 
>   ql/src/test/results/clientpositive/merge4.q.out 121b724 
>   ql/src/test/results/clientpositive/metadataOnlyOptimizer.q.out 1fcbc0a 
>   ql/src/test/results/clientpositive/optimize_nullscan.q.out 4eb498e 
>   ql/src/test/results/clientpositive/script_env_var1.q.out 8e1075a 
>   ql/src/test/results/clientpositive/script_env_var2.q.out 89f3606 
>   ql/src/test/results/clientpositive/spark/groupby_sort_1_23.q.out 569501f 
>   ql/src/test/results/clientpositive/spark/groupby_sort_skew_1_23.q.out 
> 6e66697 
>   ql/src/test/results/clientpositive/spark/join34.q.out c337093 
>   ql/src/test/results/clientpositive/spark/join35.q.out 2b217c1 
>   ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out 1f9985f 
>   ql/src/test/results/clientpositive/spark/optimize_nullscan.q.out 3a8efcf 
>   ql/src/test/results/clientpositive/spark/script_env_var1.q.out 8e1075a 
>   ql/src/test/results/clientpositive/spark/script_env_var2.q.out 89f3606 
>   ql/src/test/results/clientpositive/spark/union3.q.out 1e79c34 
>   ql/src/test/results/clientpositive/spark/union_null.q.out 4574a2e 
>   ql/src/test/results/clientpositive/spark/union_ppr.q.out 6204de4 
>   ql/src/test/results/clientpositive/spark/union_remove_25.q.out d36a246 
>   ql/src/test/results/clientpositive/tez/cbo_union.q.out 1fd88ec 
>   ql/src/test/results/clientpositive/tez/optimize_nullscan.q.out da456c7 
>   ql/src/test/results/clientpositive/tez/script_env_var1.q.out 8e1075a 
>   ql/src/test/results/clientpositive/tez/script_env_var2.q.out 89f3606 
>   ql/src/test/results/clientpositive/tez/union3.q.out 3dad621 
>   ql/src/test/results/clientpositive/tez/unionDistinct_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/unionDistinct_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/union22.q.out 672fa77 
>   ql/src/test/results/clientpositive/union24.q.out 0657b65 
>   ql/src/test/results/clientpositive/union3.q.out 810d3af 
>   ql/src/test/results/clientpositive/unionDistinct_1.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/unionDistinct_2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/union_null.q.out e2897ff 
>   ql/src/test/results/clientpositive/union_ppr.q.out 0610337 
>   ql/src/test/results/clientpositive/union_remove_25.q.out 4eae6d2 
>   ql/src/test/results/clientpositive/union_top_level.q.out 72e684c 
>   ql/src/test/results/clientpositive/varchar_union1.q.out ac4e86c 
>   ql/src/test/results/clientpositive/vector_multi_insert.q.out 36ae859 
> 
> Diff: https://reviews.apache.org/r/28797/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> pengcheng xiong
> 
>

Reply via email to