[ https://issues.apache.org/jira/browse/HIVE-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289829#comment-14289829 ]
Sushanth Sowmyan commented on HIVE-9436: ---------------------------------------- Randomly sampling some of the test failures: {noformat} source/itests/qtest/../../itests/qtest/target/qfile-results/clientpositive/udaf_histogram_numeric.q.out /home/hiveptest/54.205.215.38-hiveptest-1/apache-svn-trunk-source/itests/qtest/../../ql/src/test/results/clientpositive/udaf_histogram_numeric.q.out 9c9 < [{"x":139.16078431372554,"y":255.0},{"x":386.1428571428572,"y":245.0}] --- > [{"x":135.0284552845532,"y":246.0},{"x":381.39370078740143,"y":254.0}] {noformat} {noformat} Running: diff -a /home/hiveptest/54.159.206.72-hiveptest-1/apache-svn-trunk-source/itests/qtest/../../itests/qtest/target/qfile-results/clientpositive/auto_join12.q.out /home/hiveptest/54.159.206.72-hiveptest-1/apache-svn-trunk-source/itests/qtest/../../ql/src/test/results/clientpositive/auto_join12.q.out 32c32 < $hdt$_0:$hdt$_0:$hdt$_0:$hdt$_0:src --- > $hdt$_0:$hdt$_0:$hdt$_0:$hdt$_0:$hdt$_0:src 35c35 < $hdt$_0:$hdt$_0:$hdt$_1:$hdt$_1:$hdt$_1:src --- > $hdt$_0:$hdt$_0:$hdt$_1:$hdt$_1:$hdt$_1:$hdt$_1:src 39c39 < $hdt$_0:$hdt$_0:$hdt$_0:$hdt$_0:src --- > $hdt$_0:$hdt$_0:$hdt$_0:$hdt$_0:$hdt$_0:src 54c54 < $hdt$_0:$hdt$_0:$hdt$_1:$hdt$_1:$hdt$_1:src --- > $hdt$_0:$hdt$_0:$hdt$_1:$hdt$_1:$hdt$_1:$hdt$_1:src {noformat} Neither of those have anything whatsoever to do with retries. Also, I see some other errors reporting "junit.framework.AssertionFailedError: Client Execution failed with error code = 40000 running", which is similar to what's reported in HIVE-8997. Is there a test flakiness issue right now in trunk? > RetryingMetaStoreClient does not retry JDOExceptions > ---------------------------------------------------- > > Key: HIVE-9436 > URL: https://issues.apache.org/jira/browse/HIVE-9436 > Project: Hive > Issue Type: Bug > Affects Versions: 0.14.0, 0.13.1 > Reporter: Sushanth Sowmyan > Assignee: Sushanth Sowmyan > Attachments: HIVE-9436.2.patch, HIVE-9436.patch > > > RetryingMetaStoreClient has a bug in the following bit of code: > {code} > } else if ((e.getCause() instanceof MetaException) && > e.getCause().getMessage().matches("JDO[a-zA-Z]*Exception")) { > caughtException = (MetaException) e.getCause(); > } else { > throw e.getCause(); > } > {code} > The bug here is that java String.matches matches the entire string to the > regex, and thus, that match will fail if the message contains anything before > or after JDO[a-zA-Z]\*Exception. The solution, however, is very simple, we > should match .\*JDO[a-zA-Z]\*Exception.\* -- This message was sent by Atlassian JIRA (v6.3.4#6332)