[ 
https://issues.apache.org/jira/browse/HIVE-9428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290636#comment-14290636
 ] 

Xuefu Zhang commented on HIVE-9428:
-----------------------------------

[~lirui], It's fine to check both isDone() and get(). As to the exception, 
since we eat the exception, I think it makes sense to log it here. Something 
like: LOG.log("Failed to ...", ex);

> LocalSparkJobStatus may return failed job as successful [Spark Branch]
> ----------------------------------------------------------------------
>
>                 Key: HIVE-9428
>                 URL: https://issues.apache.org/jira/browse/HIVE-9428
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Spark
>            Reporter: Rui Li
>            Assignee: Rui Li
>            Priority: Minor
>         Attachments: HIVE-9428.1-spark.patch, HIVE-9428.2-spark.patch
>
>
> Future is done doesn't necessarily mean the job is successful. We should rely 
> on SparkJobInfo to get job status whenever it's available.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to