----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30264/#review69734 -----------------------------------------------------------
Ship it! Looks good to me, leave it to Xuefu to review the other comments. - Szehon Ho On Jan. 27, 2015, 2:03 a.m., chengxiang li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30264/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 2:03 a.m.) > > > Review request for hive, Szehon Ho and Xuefu Zhang. > > > Bugs: HIVE-9211 > https://issues.apache.org/jira/browse/HIVE-9211 > > > Repository: hive-git > > > Description > ------- > > MiniSparkOnYarnCluster is enabled for unit test, Spark is deployed on > miniYarnCluster on yarn-client mode, all qfiles in minimr.query.files are > enabled in this unit test except 3 qfile: bucket_num_reducers.q, > bucket_num_reducers2.q, udf_using.q, which is not supported in HoS. > > > Diffs > ----- > > data/conf/spark/hive-site.xml 016f568 > data/conf/spark/standalone/hive-site.xml PRE-CREATION > data/conf/spark/yarn-client/hive-site.xml PRE-CREATION > itests/pom.xml e1e88f6 > itests/qtest-spark/pom.xml d12fad5 > itests/src/test/resources/testconfiguration.properties f583aaf > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 095b9bd > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java > 41a2ab7 > ql/src/test/results/clientpositive/spark/bucket5.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/bucket6.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/bucketizedhiveinputformat.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/constprog_partitioner.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/empty_dir_in_table.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/external_table_with_space_in_location_path.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/file_with_header_footer.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/import_exported_table.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/index_bitmap3.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/index_bitmap_auto.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/infer_bucket_sort_bucketed_table.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/infer_bucket_sort_dyn_part.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/infer_bucket_sort_map_operators.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/infer_bucket_sort_merge.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/infer_bucket_sort_num_buckets.q.out > PRE-CREATION > > ql/src/test/results/clientpositive/spark/infer_bucket_sort_reducers_power_two.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/input16_cc.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/list_bucket_dml_10.q.java1.7.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/load_fs2.q.out PRE-CREATION > > ql/src/test/results/clientpositive/spark/load_hdfs_file_with_space_in_the_name.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/parallel_orderby.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/ql_rewrite_gbtoidx.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/ql_rewrite_gbtoidx_cbo_1.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/ql_rewrite_gbtoidx_cbo_2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/quotedid_smb.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/reduce_deduplicate.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/remote_script.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/root_dir_external_table.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/schemeAuthority.q.out PRE-CREATION > ql/src/test/results/clientpositive/spark/schemeAuthority2.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/temp_table_external.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/truncate_column_buckets.q.out > PRE-CREATION > ql/src/test/results/clientpositive/spark/uber_reduce.q.out PRE-CREATION > shims/0.20S/src/main/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java > b17f465 > shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java > a61c3ac > > shims/0.23/src/main/java/org/apache/hadoop/hive/shims/MiniSparkOnYARNCluster.java > PRE-CREATION > shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java > 064304c > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java > aea90db > > Diff: https://reviews.apache.org/r/30264/diff/ > > > Testing > ------- > > > Thanks, > > chengxiang li > >
