> On Jan. 21, 2015, 6:43 a.m., Lefty Leverenz wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 372-374 > > <https://reviews.apache.org/r/29807/diff/2/?file=827704#file827704line372> > > > > Shouldn't "long" & "LONG" be included in the names > > "hive.metastore.server.running.method.timeout" & > > "METASTORE_SERVER_RUNNING_METHOD_TIMEOUT"? > > > > Also, please specify the JIRA number (HIVE-9253) in this review > > request, either under Bugs in the Information section or in the Summary, or > > both.
Thanks for your review and suggestion! Lefty. I have renamed it in the new patch. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29807/#review68878 ----------------------------------------------------------- On Jan. 22, 2015, 8:22 a.m., Dong Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29807/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 8:22 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-9253: MetaStore server should support timeout for long running requests > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 5e00575 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > caad948 > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > 564ac8b > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingHMSHandler.java > 01ad36a > metastore/src/java/org/apache/hadoop/hive/metastore/RuntimeTimeout.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/RuntimeTimeoutException.java > PRE-CREATION > > metastore/src/java/org/apache/hadoop/hive/metastore/SessionPropertiesListener.java > PRE-CREATION > > metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java > PRE-CREATION > metastore/src/test/org/apache/hadoop/hive/metastore/TestRuntimeTimeout.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29807/diff/ > > > Testing > ------- > > UT passed > > > Thanks, > > Dong Chen > >
