----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30437/#review70504 -----------------------------------------------------------
Look at number of files in GREATEST udf patch https://reviews.apache.org/r/30003/diff/# add your function to show_functions.q.out add negative q and q.out files what if date not valid 2014-01-40 or null add positive q and q.out files to build and test hive cd hive mvn clean install -Phadoop-2 -DskipTests mvn test -Phadoop-2 -Dtest=TestGenericUDFGreatest cd itests mvn clean install -Phadoop-2 -DskipTests cd qtest mvn test -Dtest=TestNegativeCliDriver -Dqfile=udf_greatest_error_1.q -Dtest.output.overwrite=true -Phadoop-2 mvn test -Dtest=TestCliDriver -Dqfile=udf_greatest.q -Dtest.output.overwrite=true -Phadoop-2 - Alexander Pivovarov On Jan. 30, 2015, 1:43 a.m., XIAOBING ZHOU wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30437/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 1:43 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > This is used to track work to build Oracle like months_between. Here's > semantics: > MONTHS_BETWEEN returns number of months between dates date1 and date2. If > date1 is later than date2, then the result is positive. If date1 is earlier > than date2, then the result is negative. If date1 and date2 are either the > same days of the month or both last days of months, then the result is always > an integer. Otherwise Oracle Database calculates the fractional portion of > the result based on a 31-day month and considers the difference in time > components date1 and date2. > > https://issues.apache.org/jira/browse/HIVE-9518 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 23d77ca > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java > 1ecd835 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiffBase.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMonthsBetween.java > PRE-CREATION > ql/src/test/TestGenericUDFMonthsBetween.java PRE-CREATION > > Diff: https://reviews.apache.org/r/30437/diff/ > > > Testing > ------- > > SEE ALSO ql/src/test/TestGenericUDFMonthsBetween.java > > > Thanks, > > XIAOBING ZHOU > >