[ https://issues.apache.org/jira/browse/HIVE-9151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300086#comment-14300086 ]
Hive QA commented on HIVE-9151: ------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12695786/HIVE-9151.1.patch {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 7409 tests executed *Failed tests:* {noformat} org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler.org.apache.hive.hcatalog.hbase.TestPigHBaseStorageHandler org.apache.hive.hcatalog.templeton.TestWebHCatE2e.getHiveVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2603/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2603/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2603/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12695786 - PreCommit-HIVE-TRUNK-Build > Checking s against null in TezJobMonitor#getNameWithProgress() should be done > earlier > ------------------------------------------------------------------------------------- > > Key: HIVE-9151 > URL: https://issues.apache.org/jira/browse/HIVE-9151 > Project: Hive > Issue Type: Bug > Affects Versions: 1.0.0, 1.2.0, 1.1.0 > Reporter: Ted Yu > Assignee: Prasanth Jayachandran > Priority: Minor > Attachments: HIVE-9151.1.patch > > > {code} > int spaceRemaining = COLUMN_1_WIDTH - s.length() - 1; > String trimmedVName = s; > // if the vertex name is longer than column 1 width, trim it down > // "Tez Merge File Work" will become "Tez Merge File.." > if (s != null && s.length() > COLUMN_1_WIDTH) { > {code} > s is dereferenced first, rendering the null check ineffective. -- This message was sent by Atlassian JIRA (v6.3.4#6332)