----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30254/#review70773 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java <https://reviews.apache.org/r/30254/#comment116181> Jesus, Instead of traversing the operator tree seperately looking for RS,GB,Filter,Limit it seems like if we have a method that can traverse the op tree and group ops to different buckets (like RS, Fil, GB,Sel, join, union...) that would be better. That way we traverse the tree once. The other API (like existsOrdering...) could then take a collection of operators (RS, FIL ...)and asnwer the question. - John Pullokkaran On Feb. 3, 2015, 10:52 a.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30254/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 10:52 a.m.) > > > Review request for hive and John Pullokkaran. > > > Bugs: HIVE-9444 > https://issues.apache.org/jira/browse/HIVE-9444 > > > Repository: hive-git > > > Description > ------- > > HIVE-9444 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorUtils.java > 4d9d1da77394125cfcb9ac9ccf1c00528664b981 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GlobalLimitOptimizer.java > c9848dacd1a02db321583c2b91eb6d7317c295ff > > Diff: https://reviews.apache.org/r/30254/diff/ > > > Testing > ------- > > Existing tests (global_limit.q). > > > Thanks, > > Jesús Camacho Rodríguez > >
