Re: Review Request 30740: HIVE-9596 move standard getDisplayString impl to GenericUDF

Fri, 06 Feb 2015 11:16:55 -0800 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30740/
-----------------------------------------------------------

(Updated Feb. 6, 2015, 7:16 p.m.)


Review request for hive and Jason Dere.


Changes
-------

fixed imports


Bugs: HIVE-9596
    https://issues.apache.org/jira/browse/HIVE-9596


Repository: hive-git


Description
-------

HIVE-9596 move standard getDisplayString impl to GenericUDF


Diffs (updated)
-----

  
contrib/src/java/org/apache/hadoop/hive/contrib/genericudf/example/GenericUDFDBOutput.java
 1a541471ec0d2518b1e02a1f99d52546a377a4d8 
  
itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEvaluateNPE.java
 4080c9f38da1eaf6d9976907911ffd198c12395b 
  
itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaBoolean.java
 bf6c7c2325fa834d23bff47f61639b08be5a2838 
  
itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestGetJavaString.java
 914cebf4c49521d0521a6d0e5da3e0560863ecae 
  
itests/util/src/main/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTestTranslate.java
 0ab8d0b068d29525ad063c39e763cb604df193f7 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFEWAHBitmapBop.java
 58ea3bac80f363350174a8358cce8a5aa78c462a 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDFReflect.java
 8d731965b26ece2f7055c69830ab8f39126f212d 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDF.java 
e3fb55872c4ab873b1d93ad27f7f74a26cf8d5f8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java 
d655683715fa5ff75cf2ce4a32e73201ad37915d 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java 
55943edfb37ffdd706525f2e57e4d68311088fed 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFArray.java 
44eb44ce7710178a0f6f816ce98680ccc4909688 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrue.java 
e5999d681804689d1386515d56115cafede7d883 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java 
39875fcca4b72e26c21f2a916990baefdbe6d7a6 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java 
c86a9bd149506e8661c613e337092e15aa21e403 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseTrim.java 
b12f856756ea0a1f3dabbd360c99509899b5cc87 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java 
03e5b70a51e760216544f5fa4e5c59e6be5bee1c 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java 
fac13ba02fd75810a8db3918fafc3cfe6f1f47ef 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java 
8763942528b8ffa210fa66d5ef192e72e19ddf8a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java 
9ee948019189b8d38c55f7a82a460e7f9a60e101 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java 
e2db7b1ff231d59b817e8e71981319f30b7eecf4 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java 
1ecd83556998396cb65188301331785bcc807e5d 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java 
cb13060808b22ab781cab5d277925ce7a7bd30d2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDecode.java 
4d8473f0d85b51833478ae9f95df54ee29113b14 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEWAHBitmapEmpty.java
 4a14a65c67a9d52bfce95e0c622ba8551d819872 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFElt.java 
85ba99348051f79e07e87515441f9e74e37356dd 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEncode.java 
ee59e39393fa0f5712a8e93e21c2bf0299318f55 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFField.java 
d7e65fa662375c65c2084713cf9ce129e0abb0a3 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFloorCeilBase.java 
894b649952921f407da6a2199bf91acf23f2becf 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java 
3586b8d3ae6d89f48af88657ba950ba00b953cc5 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGreatest.java 
5d6925b789367810d2f696d493d06af0c898b879 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFHash.java 
3e04951aab25662c90b6ad1037757e973b3ef222 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFIf.java 
7009026a66abf624f1589065db4a142691afcee2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInFile.java 
5163cefd361c84cdcd832b1ccd393a96b001243a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInitCap.java 
067f3d1ed4fced824b8b624b97304c4323238856 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInstr.java 
db5b8c94499bbc353703ca78fb524a4b21ca85f5 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLastDay.java 
911ee46e8dad310ee73e6d174aca4501b0e95c09 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLeadLag.java 
ec49f05a656213fcf0983433a31ab347b6a3dc70 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLocate.java 
aaf6dce7f0e53b8b06dea609f1a55f79f11540a2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java 
aa04b38ca6e581c0d58a949b26a3a5b64bc6e710 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMacro.java 
9400962a011e5e294b9424ef9caf992d9eee80b0 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapKeys.java 
1d4bceff273c5461e86ce22b8b8ff71d7571e8c8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFMapValues.java 
bd08a21e105d3545f52b7cba15f3c13b58c1a2b4 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFNamedStruct.java 
7b18d8234effc89abe0b3e3dedfca57b62fb8abf 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPower.java 
c1fe4aa4718f9765f55ba612e2702317eb5e8e7b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java 
e9c0cc4e9c10d054d32e843fb9de64eafa60faff 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java 
387de5e3103e2399a3fdb9b2376ac790501eab8e 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSentences.java 
c24c0ec1948ad6279babeb7599ec707de514ea2b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSize.java 
c31ab54b29fdb7d92abbd0517a1eea3b5909380f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSortArray.java 
40d1bdd267c9e6a6d9f37e434416a2e03220af25 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFSplit.java 
e11f6c1e7fb654708474f30016f99ccb25aa4cfb 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java 
4c21a7e3aa8b17e3bf9a5a8b74c6c1a552f65a93 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStruct.java 
7c8dfcf5490370260370331bc83ae021518a60d8 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTranslate.java 
814ec6a0283d6b5839181925b18839938025b77a 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java 
db4a2cf46c3cfd2273a9e61e6b76aa5fd3c8dbed 

Diff: https://reviews.apache.org/r/30740/diff/


Testing
-------


Thanks,

Alexander Pivovarov

Reply via email to