-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24609/
-----------------------------------------------------------

(Updated Feb. 9, 2015, 8:13 p.m.)


Review request for hive.


Changes
-------

Thank you Szehon,

All comments for this diff have been applied.
Please review and help me apply the patch, if it looks ok.

Thanks
Sachin


Bugs: https://issues.apache.org/jira/browse/HIVE-7653
    
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-7653


Repository: hive-git


Description
-------

Hi,

I have submitted a patch for the following issue:
https://issues.apache.org/jira/browse/HIVE-7653

But the build is failing due to some other issue.
Its been failing for the past 70 builds or so and I don't think its related to 
my change.
Also, my local build for the same is passing.

Can someone please help me override/fix this test-failure?

Also, a code review of the above patch would be much appreciated.

Thanks
Sachin


Diffs (updated)
-----

  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroDeserializer.java 
a2558f2 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerializer.java 809c2f2 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/InstanceCache.java d848005 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/SchemaToTypeInfo.java 
3998737 
  serde/src/test/org/apache/hadoop/hive/serde2/avro/TestAvroSerializer.java 
b573f50 
  serde/src/test/org/apache/hadoop/hive/serde2/avro/TestInstanceCache.java 
1df88ee 

Diff: https://reviews.apache.org/r/24609/diff/


Testing
-------

All tests pass.
Also added a new unit-test for the patch.


Thanks,

Sachin Goyal

Reply via email to