[
https://issues.apache.org/jira/browse/HIVE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129218#comment-13129218
]
jirapos...@reviews.apache.org commented on HIVE-2470:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2078/
-----------------------------------------------------------
(Updated 2011-10-17 21:19:30.440767)
Review request for hive, Carl Steinbach, John Sichi, and Igor Kabiljo.
Changes
-------
Rebase!
Summary
-------
ConstantObjectInspectors were introduced in a previous patch so that UDF's
could have access to constant values at initialize time. This diff adds the
following improvements:
1.) Extends this functionality beyond primitive types to List/Map types.
2.) Fixes a bug in ExprNodeGenericFuncDesc where the constant value would not
propagate beyond one level of evaluation.
3.) Adds a helper class to make functions constant-aware. By inheriting from
this class they return constant OIs if all their arguments are constant, and
they cache the result so that computation is only done during initialize().
Some functions such as ARRAY/IF/MAP have been migrated.
This addresses bug HIVE-2470.
https://issues.apache.org/jira/browse/HIVE-2470
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/SimpleGenericUDAFParameterInfo.java
3277b98
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFPercentileApprox.java
678607b
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/AbstractGenericUDAFResolver.java
766e473
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFParameterInfo.java
04cfc28
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1110cfa
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java cbbfffb
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndex.java
c179d44
Diff: https://reviews.apache.org/r/2078/diff
Testing
-------
ant test
Thanks,
Jonathan
> Improve support for Constant Object Inspectors
> ----------------------------------------------
>
> Key: HIVE-2470
> URL: https://issues.apache.org/jira/browse/HIVE-2470
> Project: Hive
> Issue Type: Improvement
> Reporter: Jonathan Chang
> Assignee: Jonathan Chang
> Fix For: 0.9.0
>
> Attachments: HIVE-1360.part2.patch, HIVE-2470.patch,
> HIVE-2470.patch.3, HIVE-2470.patch.4, HIVE-2470.patch.5, HIVE-2470.patch.6,
> HIVE-2470.patch.8
>
>
> ConstantObjectInspectors are nice but they need to be more widely supported
> and used. In particular,
> * More functions need to be using them.
> * There need to be facilities for propagating constness.
> * Support for complex types must be added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
