----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31395/ -----------------------------------------------------------
(Updated Feb. 25, 2015, 7:23 p.m.) Review request for hive. Changes ------- Patch V2. removd the MetaException Wrapping Repository: hive-git Description ------- When org.apache.thrift.transport.TTransportException is thrown for issues like socket timeout, the retry via RetryingMetaStoreClient happens only in certain cases. Retry happens for the getDatabase call in but not for getAllDatabases(). The reason is RetryingMetaStoreClient checks for TTransportException being the cause for InvocationTargetException. But in case of some calls such as getAllDatabases in HiveMetastoreClient, all exceptions get wrapped in a MetaException. We should remove this unnecessary wrapping of exceptions for certain functions in HMC. Diffs (updated) ----- metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 4778bb6 Diff: https://reviews.apache.org/r/31395/diff/ Testing ------- Thanks, XIAOBING ZHOU