----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31771/#review75918 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFactorial.java <https://reviews.apache.org/r/31771/#comment123243> Which version of commons-math do we use in Hive? Looks like ArithmeticUtils.factorial() has been deprecated in favor of CombinatoricsUtils.factorial(). ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFFactorial.java <https://reviews.apache.org/r/31771/#comment123244> Is there a typo in the function name? - Jason Dere On March 5, 2015, 7:46 p.m., Alexander Pivovarov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31771/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 7:46 p.m.) > > > Review request for hive and Jason Dere. > > > Bugs: HIVE-9857 > https://issues.apache.org/jira/browse/HIVE-9857 > > > Repository: hive-git > > > Description > ------- > > HIVE-9857 Create Factorial UDF > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java > 20811abba06c0c08751c57adad854a377abc300e > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFactorial.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFFactorial.java > PRE-CREATION > ql/src/test/queries/clientpositive/udf_factorial.q PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out > f2bec4785dbc110f64b1b2820c6a52f3f2a369a7 > ql/src/test/results/clientpositive/udf_factorial.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/31771/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Pivovarov > >
